about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLaurențiu Nicola <lnicola@users.noreply.github.com>2025-04-15 14:10:13 +0000
committerGitHub <noreply@github.com>2025-04-15 14:10:13 +0000
commita6e7f0747e6214edb597e9ebd25a86036e425888 (patch)
tree03c99215bc0a33559d3787076a722276c9accb1d
parentd9b61b3382e83c8e3aaab0239da74e0526aed283 (diff)
parent4b5126e8b85f9c2c27a38fae2bc6de0beeb2cfc6 (diff)
downloadrust-a6e7f0747e6214edb597e9ebd25a86036e425888.tar.gz
rust-a6e7f0747e6214edb597e9ebd25a86036e425888.zip
Merge pull request #19586 from Kobzol/manylinux-instead-of-zigbuild
Use a Docker container instead of Zig for building with old(er) glibc on x64 Linux
-rw-r--r--src/tools/rust-analyzer/.github/workflows/release.yaml10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/tools/rust-analyzer/.github/workflows/release.yaml b/src/tools/rust-analyzer/.github/workflows/release.yaml
index c76d3da5f8d..9d2ff95d286 100644
--- a/src/tools/rust-analyzer/.github/workflows/release.yaml
+++ b/src/tools/rust-analyzer/.github/workflows/release.yaml
@@ -36,7 +36,9 @@ jobs:
             code-target: win32-arm64
           - os: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-            zig_target: x86_64-unknown-linux-gnu.2.28
+            # Use a container with glibc 2.28
+            # Zig is not used because it doesn't work with PGO
+            container: quay.io/pypa/manylinux_2_28_x86_64
             code-target: linux-x64
           - os: ubuntu-latest
             target: aarch64-unknown-linux-gnu
@@ -71,6 +73,12 @@ jobs:
         with:
           node-version: 22
 
+      - name: Install rustup
+        if: ${{ matrix.container }}
+        run: |
+          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal
+          echo "$HOME/.cargo/bin" >> $GITHUB_PATH
+
       - name: Install Rust toolchain
         run: |
           rustup update --no-self-update stable