diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2022-05-29 01:12:30 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-29 01:12:30 +0200 |
| commit | a777d50b24e6f9cf0ea056b2a048cfec428d0892 (patch) | |
| tree | d7a009dc38039b5b7005a4f3f885e539b30505f3 | |
| parent | 239287f013b21d18c8ddd5bf5419629d43dca484 (diff) | |
| parent | 643c508e869c1bed9ebd694ad4d2eb0cdf6baf24 (diff) | |
Rollup merge of #97478 - JohnTitor:fixme-fn-decl, r=compiler-errors
Remove FIXME on `ExtCtxt::fn_decl()` `ExtCtxt::fn_decl()` is used like `self.fn_decl(..)` or `self.cx.fn_decl(..)`, coverting it to an assoc fn, for example, makes it inconvenience (e.g. `self.cx.fn_decl(..)` would be longer to represent). Given that, it doesn't seem a "FIXME" thing and unused `self` is okay, I think.
| -rw-r--r-- | compiler/rustc_expand/src/build.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rustc_expand/src/build.rs b/compiler/rustc_expand/src/build.rs index 301c67f7026..56d0263269b 100644 --- a/compiler/rustc_expand/src/build.rs +++ b/compiler/rustc_expand/src/build.rs @@ -514,7 +514,7 @@ impl<'a> ExtCtxt<'a> { } } - // FIXME: unused `self` + // `self` is unused but keep it as method for the convenience use. pub fn fn_decl(&self, inputs: Vec<ast::Param>, output: ast::FnRetTy) -> P<ast::FnDecl> { P(ast::FnDecl { inputs, output }) } |