diff options
| author | Samuel Moelius <sam@moeli.us> | 2024-12-29 07:44:06 -0500 |
|---|---|---|
| committer | Samuel Moelius <sam@moeli.us> | 2024-12-29 07:44:06 -0500 |
| commit | a7adb8217ebe1d92e9406f846834f9c57246b449 (patch) | |
| tree | 99ddcb1d4f03f62f6f059d4d9b3ce6b56a0d039c | |
| parent | c8ba3e1d7a92a591e01c13df79a868fff8876534 (diff) | |
| download | rust-a7adb8217ebe1d92e9406f846834f9c57246b449.tar.gz rust-a7adb8217ebe1d92e9406f846834f9c57246b449.zip | |
Move `format_push_string` and `format_collect` to pedantic
| -rw-r--r-- | clippy_dev/src/new_lint.rs | 2 | ||||
| -rw-r--r-- | clippy_lints/src/endian_bytes.rs | 3 | ||||
| -rw-r--r-- | clippy_lints/src/format_push_string.rs | 2 | ||||
| -rw-r--r-- | clippy_lints/src/methods/mod.rs | 2 |
4 files changed, 6 insertions, 3 deletions
diff --git a/clippy_dev/src/new_lint.rs b/clippy_dev/src/new_lint.rs index 35dd986ff61..7328ee1ac4f 100644 --- a/clippy_dev/src/new_lint.rs +++ b/clippy_dev/src/new_lint.rs @@ -255,6 +255,7 @@ fn get_lint_file_contents(lint: &LintData<'_>, enable_msrv: bool) -> String { let name_camel = to_camel_case(lint.name); let name_upper = lint_name.to_uppercase(); + #[expect(clippy::format_push_string)] result.push_str(&if enable_msrv { formatdoc!( r" @@ -279,6 +280,7 @@ fn get_lint_file_contents(lint: &LintData<'_>, enable_msrv: bool) -> String { let _: fmt::Result = writeln!(result, "{}", get_lint_declaration(&name_upper, category)); + #[expect(clippy::format_push_string)] result.push_str(&if enable_msrv { formatdoc!( r" diff --git a/clippy_lints/src/endian_bytes.rs b/clippy_lints/src/endian_bytes.rs index 209104c5385..f3208497b3c 100644 --- a/clippy_lints/src/endian_bytes.rs +++ b/clippy_lints/src/endian_bytes.rs @@ -7,6 +7,7 @@ use rustc_middle::lint::in_external_macro; use rustc_middle::ty::Ty; use rustc_session::declare_lint_pass; use rustc_span::Symbol; +use std::fmt::Write; declare_clippy_lint! { /// ### What it does @@ -184,7 +185,7 @@ fn maybe_lint_endian_bytes(cx: &LateContext<'_>, expr: &Expr<'_>, prefix: Prefix help_str.push_str("either of "); } - help_str.push_str(&format!("`{ty}::{}` ", lint.as_name(prefix))); + write!(help_str, "`{ty}::{}` ", lint.as_name(prefix)).unwrap(); if i != len && !only_one { help_str.push_str("or "); diff --git a/clippy_lints/src/format_push_string.rs b/clippy_lints/src/format_push_string.rs index 8b1f86cbb91..2b3923ab468 100644 --- a/clippy_lints/src/format_push_string.rs +++ b/clippy_lints/src/format_push_string.rs @@ -35,7 +35,7 @@ declare_clippy_lint! { /// ``` #[clippy::version = "1.62.0"] pub FORMAT_PUSH_STRING, - restriction, + pedantic, "`format!(..)` appended to existing `String`" } declare_lint_pass!(FormatPushString => [FORMAT_PUSH_STRING]); diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs index 810287fa541..baae3048d44 100644 --- a/clippy_lints/src/methods/mod.rs +++ b/clippy_lints/src/methods/mod.rs @@ -3514,7 +3514,7 @@ declare_clippy_lint! { /// ``` #[clippy::version = "1.73.0"] pub FORMAT_COLLECT, - perf, + pedantic, "`format!`ing every element in a collection, then collecting the strings into a new `String`" } |