about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthias Krüger <476013+matthiaskrgr@users.noreply.github.com>2025-04-09 20:23:10 +0200
committerGitHub <noreply@github.com>2025-04-09 20:23:10 +0200
commitac41b940f2202fe55385240007cfaa906ab78ba4 (patch)
treea867c30a052170ad54de3f797eb0525451d6e427
parentd5f930fe76ab17ad5ccd4834f3cea10a99022cf2 (diff)
parent30f56df6f9fe396758213b5d9339e774339f5455 (diff)
downloadrust-ac41b940f2202fe55385240007cfaa906ab78ba4.tar.gz
rust-ac41b940f2202fe55385240007cfaa906ab78ba4.zip
Rollup merge of #139488 - GuillaumeGomez:add-missing-gui-test, r=camelid
Add missing regression GUI test

Add missing GUI test for #139282 (and also fixes the invalid CSS).

cc `@lolbinarycat`
r? `@notriddle`
-rw-r--r--src/librustdoc/html/static/css/rustdoc.css2
-rw-r--r--tests/rustdoc-gui/settings.goml14
2 files changed, 15 insertions, 1 deletions
diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css
index aa8df35258d..74d23b3143f 100644
--- a/src/librustdoc/html/static/css/rustdoc.css
+++ b/src/librustdoc/html/static/css/rustdoc.css
@@ -1447,7 +1447,7 @@ so that we can apply CSS-filters to change the arrow color in themes */
 	cursor: pointer;
 }
 .setting-check input {
-	flex-shrink: 0,
+	flex-shrink: 0;
 }
 
 .setting-radio input:checked {
diff --git a/tests/rustdoc-gui/settings.goml b/tests/rustdoc-gui/settings.goml
index 4ab5b83d7c4..11d3696ccf6 100644
--- a/tests/rustdoc-gui/settings.goml
+++ b/tests/rustdoc-gui/settings.goml
@@ -314,6 +314,13 @@ compare-elements-position: (".sub form", "#settings", ["x"])
 // Check that setting-line has the same margin in this mode as in the popover.
 assert-css: (".setting-line", {"margin": |setting_line_margin|})
 
+// We will check that the checkboxes size doesn't change either.
+assert-size: (
+    "#settings label > input[type='checkbox']",
+    {"width": 19, "height": 19},
+    ALL,
+)
+
 // We now check the display with JS disabled.
 assert-false: "noscript section"
 javascript: false
@@ -327,3 +334,10 @@ reload:
 set-window-size: (300, 1000)
 wait-for: "#settings"
 assert-css: (".setting-radio", {"cursor": "pointer"})
+
+// We ensure that the checkboxes size didn't change.
+assert-size: (
+    "#settings label > input[type='checkbox']",
+    {"width": 19, "height": 19},
+    ALL,
+)