about summary refs log tree commit diff
diff options
context:
space:
mode:
authorNiko Matsakis <niko@alum.mit.edu>2014-12-29 11:00:56 -0500
committerNiko Matsakis <niko@alum.mit.edu>2014-12-30 09:36:22 -0500
commitadca15a151422a72d69c39ade946f36a2ff072a6 (patch)
tree15c1e505f7cb56cca6c757700c70e5e95f355870
parent7836c72ebae3124443fd4009b65eb2cc4cc6cf38 (diff)
downloadrust-adca15a151422a72d69c39ade946f36a2ff072a6.tar.gz
rust-adca15a151422a72d69c39ade946f36a2ff072a6.zip
Add a FIXME relating to using `ast::Name`
-rw-r--r--src/librustc/middle/def.rs1
-rw-r--r--src/librustc_typeck/astconv.rs3
-rw-r--r--src/libsyntax/ast.rs2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/librustc/middle/def.rs b/src/librustc/middle/def.rs
index 59fd41b5d29..ff1ee394966 100644
--- a/src/librustc/middle/def.rs
+++ b/src/librustc/middle/def.rs
@@ -36,6 +36,7 @@ pub enum Def {
     // A partially resolved path to an associated type `T::U` where `T` is a concrete
     // type (indicated by the DefId) which implements a trait which has an associated
     // type `U` (indicated by the Ident).
+    // FIXME(#20301) -- should use Name
     DefAssociatedPath(TyParamProvenance, ast::Ident),
     DefTrait(ast::DefId),
     DefPrimTy(ast::PrimTy),
diff --git a/src/librustc_typeck/astconv.rs b/src/librustc_typeck/astconv.rs
index 47717105164..480bba16e63 100644
--- a/src/librustc_typeck/astconv.rs
+++ b/src/librustc_typeck/astconv.rs
@@ -992,7 +992,7 @@ fn qpath_to_ty<'tcx,AC,RS>(this: &AC,
 
     return this.projected_ty(ast_ty.span,
                              trait_ref,
-                             qpath.item_name.name); // TODO change qpath to use name
+                             qpath.item_name.name);
 }
 
 // Parses the programmer's textual representation of a type into our
@@ -1155,7 +1155,6 @@ pub fn ast_ty_to_ty<'tcx, AC: AstConv<'tcx>, RS: RegionScope>(
                         this.tcx().types.err
                     }
                     def::DefAssociatedPath(provenance, assoc_ident) => {
-                        // TODO update DefAssociatedPath to use name
                         associated_path_def_to_ty(this, ast_ty, provenance, assoc_ident.name)
                     }
                     _ => {
diff --git a/src/libsyntax/ast.rs b/src/libsyntax/ast.rs
index f253943943d..12432c8c78f 100644
--- a/src/libsyntax/ast.rs
+++ b/src/libsyntax/ast.rs
@@ -764,7 +764,7 @@ pub enum Expr_ {
 pub struct QPath {
     pub self_type: P<Ty>,
     pub trait_ref: P<TraitRef>,
-    pub item_name: Ident,
+    pub item_name: Ident, // FIXME(#20301) -- should use Name
 }
 
 #[deriving(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Show, Copy)]