diff options
| author | hrxi <hrrrxi@gmail.com> | 2023-11-14 23:15:14 +0100 |
|---|---|---|
| committer | hrxi <hrrrxi@gmail.com> | 2023-11-15 00:33:14 +0100 |
| commit | b3073c536b349e6c80e24d8e85182d6d990c4c50 (patch) | |
| tree | db7ab861fc3ec929b309d49f3d4ad89c9c931747 | |
| parent | 0c42e451d643d54347aa47d7bc6c731896fe5fde (diff) | |
| download | rust-b3073c536b349e6c80e24d8e85182d6d990c4c50.tar.gz rust-b3073c536b349e6c80e24d8e85182d6d990c4c50.zip | |
Change `if_same_then_else` to be a `style` lint
CC #3770 From https://github.com/rust-lang/rust-clippy/issues/3770#issuecomment-687565594 (@flip1995): > Oh I thought I replied to this: I definitely see now that having this > as a correctness lint might be the wrong categorization. What we might > want to do is to just allow this lint, if there are comments in the > arm bodies. But a good first step would be to downgrade this lint to > style or complexity. I would vote for style since merging two arms is > not always less complex.
| -rw-r--r-- | clippy_lints/src/copies.rs | 2 | ||||
| -rw-r--r-- | tests/ui/needless_bool_assign.stderr | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/clippy_lints/src/copies.rs b/clippy_lints/src/copies.rs index e3a09636e24..3b6d4886ba3 100644 --- a/clippy_lints/src/copies.rs +++ b/clippy_lints/src/copies.rs @@ -117,7 +117,7 @@ declare_clippy_lint! { /// ``` #[clippy::version = "pre 1.29.0"] pub IF_SAME_THEN_ELSE, - correctness, + style, "`if` with the same `then` and `else` blocks" } diff --git a/tests/ui/needless_bool_assign.stderr b/tests/ui/needless_bool_assign.stderr index 7866c89bd61..244a88e6691 100644 --- a/tests/ui/needless_bool_assign.stderr +++ b/tests/ui/needless_bool_assign.stderr @@ -48,7 +48,8 @@ LL | } else { LL | | a.field = true; LL | | } | |_____^ - = note: `#[deny(clippy::if_same_then_else)]` on by default + = note: `-D clippy::if-same-then-else` implied by `-D warnings` + = help: to override `-D warnings` add `#[allow(clippy::if_same_then_else)]` error: aborting due to 4 previous errors |