about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLeón Orell Valerian Liehr <me@fmease.dev>2024-04-16 01:12:37 +0200
committerGitHub <noreply@github.com>2024-04-16 01:12:37 +0200
commitb3a82d8f9ea24453733776073f4a917b3cc578b8 (patch)
tree4736d3a66954f62f890db2c16bd04975d3057855
parentfebf858c23a221977c80b1ff89443fc2229f94fd (diff)
parenta1e76af295e39b2cb012c70ef3649731663be8ad (diff)
downloadrust-b3a82d8f9ea24453733776073f4a917b3cc578b8.tar.gz
rust-b3a82d8f9ea24453733776073f4a917b3cc578b8.zip
Rollup merge of #123462 - fmease:rn-mod-sep-to-path-sep, r=nnethercote
Cleanup: Rename `ModSep` to `PathSep`

`::` is usually referred to as the *path separator* (citation needed).

The existing name `ModSep` for *module separator* is a bit misleading since it in fact separates the segments of arbitrary path segments, not only ones resolving to modules. Let me just give a shout-out to associated items (`T::Assoc`, `<Ty as Trait>::function`) and enum variants (`Option::None`).

Motivation: Reduce friction for new contributors, prevent potential confusion.

cc `@petrochenkov`
r? nnethercote or compiler
-rw-r--r--clippy_lints/src/crate_in_macro_def.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/clippy_lints/src/crate_in_macro_def.rs b/clippy_lints/src/crate_in_macro_def.rs
index b1aa472aa03..adf6f7c4737 100644
--- a/clippy_lints/src/crate_in_macro_def.rs
+++ b/clippy_lints/src/crate_in_macro_def.rs
@@ -88,7 +88,7 @@ fn contains_unhygienic_crate_reference(tts: &TokenStream) -> Option<Span> {
         if !prev_is_dollar
             && let Some(span) = is_crate_keyword(curr)
             && let Some(next) = cursor.look_ahead(0)
-            && is_token(next, &TokenKind::ModSep)
+            && is_token(next, &TokenKind::PathSep)
         {
             return Some(span);
         }