about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAriel Ben-Yehuda <ariel.byd@gmail.com>2019-07-27 20:44:14 +0300
committerAriel Ben-Yehuda <ariel.byd@gmail.com>2019-09-24 21:11:50 +0300
commitb5665e811ba4eca0f778efb65bd3e4a69f4c3ca6 (patch)
tree2d678ebe139f8741675e8692e670bd7d1300b98f
parent1ec7ae14fa5b4b29f56d7085f632dd6301ad4815 (diff)
downloadrust-b5665e811ba4eca0f778efb65bd3e4a69f4c3ca6.tar.gz
rust-b5665e811ba4eca0f778efb65bd3e4a69f4c3ca6.zip
improve comments
-rw-r--r--src/librustc/traits/select.rs2
-rw-r--r--src/librustc/ty/mod.rs2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/librustc/traits/select.rs b/src/librustc/traits/select.rs
index 61bb53dd334..de1c71a1ba3 100644
--- a/src/librustc/traits/select.rs
+++ b/src/librustc/traits/select.rs
@@ -1326,7 +1326,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
         (result, dep_node)
     }
 
-    // Treat negative impls as unimplemented, and reservation impls as Ok(None)
+    // Treat negative impls as unimplemented, and reservation impls as ambiguity.
     fn filter_negative_and_reservation_impls(
         &self,
         candidate: SelectionCandidate<'tcx>,
diff --git a/src/librustc/ty/mod.rs b/src/librustc/ty/mod.rs
index b546a245346..6a9d7eb0750 100644
--- a/src/librustc/ty/mod.rs
+++ b/src/librustc/ty/mod.rs
@@ -2931,7 +2931,7 @@ impl<'tcx> TyCtxt<'tcx> {
             }
             (ImplPolarity::Positive, ImplPolarity::Negative) |
             (ImplPolarity::Negative, ImplPolarity::Positive) => {
-                // FIXME: when can this happen?
+                // `impl AutoTrait for Type` + `impl !AutoTrait for Type`
                 debug!("impls_are_allowed_to_overlap({:?}, {:?}) - None (differing polarities)",
                        def_id1, def_id2);
                 return None;