diff options
| author | Rich Kadel <richkadel@google.com> | 2020-11-24 18:34:10 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-24 18:34:10 -0800 |
| commit | b5fef37d23f4e4471caea5508ab18da20522e51f (patch) | |
| tree | a153486c344899b8e86a937d3d1cf1d14dbf912d | |
| parent | 51268d2735ed59b4f6b6351fd75edd0f4cf19c9f (diff) | |
| download | rust-b5fef37d23f4e4471caea5508ab18da20522e51f.tar.gz rust-b5fef37d23f4e4471caea5508ab18da20522e51f.zip | |
Apply suggestions from code review
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs | 2 | ||||
| -rw-r--r-- | src/test/run-make-fulldeps/coverage-llvmir-base/Makefile | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs b/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs index d3de960fbec..51baa2aafb7 100644 --- a/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs +++ b/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs @@ -169,7 +169,7 @@ impl CoverageMapGenerator { ); // Create the coverage data header (Note, fields 0 and 2 are now always zero, - // as of `llvm::coverage::CovMapVersion::Version4`. + // as of `llvm::coverage::CovMapVersion::Version4`.) let zero_was_n_records_val = cx.const_u32(0); let filenames_size_val = cx.const_u32(filenames_size as u32); let zero_was_coverage_size_val = cx.const_u32(0); diff --git a/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile b/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile index 2b803b95053..219ba15ad11 100644 --- a/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile +++ b/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile @@ -56,7 +56,7 @@ else -DINSTR_PROF_ORDERFILE='$(DATA_SECTION_PREFIX)__llvm_orderfile' endif -ifeq ($(LLVM_VERSION_11_PLUS),false) +ifeq ($(LLVM_VERSION_11_PLUS),true) all: test_llvm_ir else $(info Rust option `-Z instrument-coverage` requires LLVM 11 or higher. Test skipped.) |