diff options
| author | David Creswick <dcrewi@gyrae.net> | 2013-10-30 13:52:24 -0500 |
|---|---|---|
| committer | David Creswick <dcrewi@gyrae.net> | 2013-10-31 16:41:34 -0500 |
| commit | ba436a808243a4a6b9e1c052b2fad9f1a7102ff6 (patch) | |
| tree | 6f215bcd278702e216a486525f339e074ce89105 | |
| parent | 886819cca1208210cb73892f8fe4b7b9140068dc (diff) | |
| download | rust-ba436a808243a4a6b9e1c052b2fad9f1a7102ff6.tar.gz rust-ba436a808243a4a6b9e1c052b2fad9f1a7102ff6.zip | |
fix missing_doc lint on private traits
Fixes #10069.
| -rw-r--r-- | src/librustc/middle/lint.rs | 7 | ||||
| -rw-r--r-- | src/test/compile-fail/lint-missing-doc.rs | 5 |
2 files changed, 5 insertions, 7 deletions
diff --git a/src/librustc/middle/lint.rs b/src/librustc/middle/lint.rs index 1ac14dfc4b1..e1602ee0896 100644 --- a/src/librustc/middle/lint.rs +++ b/src/librustc/middle/lint.rs @@ -942,10 +942,9 @@ impl Visitor<()> for MissingDocLintVisitor { // trait (which was already linted) ast::item_impl(_, Some(*), _, _) => return, - ast::item_trait(*) if it.vis == ast::public => { - self.check_attrs(it.attrs, it.id, it.span, - ~"missing documentation for a trait"); - } + ast::item_trait(*) if it.vis != ast::public => return, + ast::item_trait(*) => self.check_attrs(it.attrs, it.id, it.span, + ~"missing documentation for a trait"), ast::item_fn(*) if it.vis == ast::public => { self.check_attrs(it.attrs, it.id, it.span, diff --git a/src/test/compile-fail/lint-missing-doc.rs b/src/test/compile-fail/lint-missing-doc.rs index 22710ad90e8..463fd352c5a 100644 --- a/src/test/compile-fail/lint-missing-doc.rs +++ b/src/test/compile-fail/lint-missing-doc.rs @@ -45,10 +45,9 @@ pub trait C {} //~ ERROR: missing documentation #[allow(missing_doc)] pub trait D {} trait Bar { - /// dox fn foo(); - fn foo2(); //~ ERROR: missing documentation - fn foo3(); //~ ERROR: missing documentation + fn foo_with_impl() { + } } impl Foo { |