about summary refs log tree commit diff
diff options
context:
space:
mode:
authorozkanonur <work@onurozkan.dev>2023-05-01 18:36:30 +0300
committerozkanonur <work@onurozkan.dev>2023-05-01 18:36:30 +0300
commitbc68de94c87537edd43f22606d84e8a2ad48e413 (patch)
treefd77219a5fabfb5f1c23cc81c03581e97891d58c
parentb7d8c88b64843d05761576aa093a34a8bc176817 (diff)
remove pointless `FIXME` in `bootstrap::download`
The suggestion given by `FIXME` to use `CompilerMetadata` for
`download_toolchain` in `bootstrap::download` can result in more
confusion. This is because `stamp_key` is not always a date; it
can also be a commit hash. Additionally, unlike in `download_beta_toolchain`,
in the `download_ci_rustc` function, `version` and `commit` values
are calculated separately.

Signed-off-by: ozkanonur <work@onurozkan.dev>
-rw-r--r--src/bootstrap/download.rs1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bootstrap/download.rs b/src/bootstrap/download.rs
index c1cf9b93fb3..3e82a381a1b 100644
--- a/src/bootstrap/download.rs
+++ b/src/bootstrap/download.rs
@@ -427,7 +427,6 @@ impl Config {
 
     fn download_toolchain(
         &self,
-        // FIXME(ozkanonur) use CompilerMetadata instead of `version: &str`
         version: &str,
         sysroot: &str,
         stamp_key: &str,