diff options
| author | varkor <github@varkor.com> | 2018-05-11 21:36:24 +0100 |
|---|---|---|
| committer | Mark Simulacrum <mark.simulacrum@gmail.com> | 2018-05-12 08:39:05 -0600 |
| commit | bd441779ff60668d29b857e3b85e77aac773ebd3 (patch) | |
| tree | 7be9217f08d03a8e37cdebfbc61681aaf969932e | |
| parent | ae41d6c32fb5177a4ef4974cbad0ed16a9b0ec67 (diff) | |
| download | rust-bd441779ff60668d29b857e3b85e77aac773ebd3.tar.gz rust-bd441779ff60668d29b857e3b85e77aac773ebd3.zip | |
Display the name of the failed file in tidy/libcoretest
| -rw-r--r-- | src/tools/tidy/src/libcoretest.rs | 23 |
1 files changed, 15 insertions, 8 deletions
diff --git a/src/tools/tidy/src/libcoretest.rs b/src/tools/tidy/src/libcoretest.rs index f6864c7f84e..363d01d964e 100644 --- a/src/tools/tidy/src/libcoretest.rs +++ b/src/tools/tidy/src/libcoretest.rs @@ -22,14 +22,21 @@ pub fn check(path: &Path, bad: &mut bool) { &libcore_path, &mut |subpath| t!(subpath.strip_prefix(&libcore_path)).starts_with("tests"), &mut |subpath| { - if subpath.ends_with(".rs") { - if t!(read_to_string(subpath)).contains("#[test]") { - tidy_error!( - bad, - "{} contains #[test]; libcore tests must be placed inside \ - `src/libcore/tests/`", - subpath.display() - ); + if let Some("rs") = subpath.extension().and_then(|e| e.to_str()) { + match read_to_string(subpath) { + Ok(contents) => { + if contents.contains("#[test]") { + tidy_error!( + bad, + "{} contains #[test]; libcore tests must be placed inside \ + `src/libcore/tests/`", + subpath.display() + ); + } + } + Err(err) => { + panic!("failed to read file {:?}: {}", subpath, err); + } } } }, |
