diff options
| author | bors <bors@rust-lang.org> | 2022-07-20 14:02:49 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-07-20 14:02:49 +0000 |
| commit | bd4439fafafb778f9d287f7369218c744381e8cd (patch) | |
| tree | d1ead3947500a83e5efa7bae4c0c1ae0e849ef44 | |
| parent | 100ea1d2d55e70970d49f8d084ccbe1ac2621020 (diff) | |
| parent | 244f29b1e7747c97922918c1d03df7ec96c2b965 (diff) | |
| download | rust-bd4439fafafb778f9d287f7369218c744381e8cd.tar.gz rust-bd4439fafafb778f9d287f7369218c744381e8cd.zip | |
Auto merge of #12829 - fasterthanlime:in-rust-tree-feature, r=Veykril
Remove `check_merge_commits` test Due to the way "git subtree" works, the `check_merge_commits` test _will_ find merge commits and fail, so we simply skip it. This changed is tracked in: * https://github.com/rust-lang/rust-analyzer/issues/12818 Maintainer impact: none
| -rw-r--r-- | crates/rust-analyzer/tests/slow-tests/tidy.rs | 50 |
1 files changed, 0 insertions, 50 deletions
diff --git a/crates/rust-analyzer/tests/slow-tests/tidy.rs b/crates/rust-analyzer/tests/slow-tests/tidy.rs index 1d666fdf0f3..dc3c5539c2c 100644 --- a/crates/rust-analyzer/tests/slow-tests/tidy.rs +++ b/crates/rust-analyzer/tests/slow-tests/tidy.rs @@ -142,56 +142,6 @@ fn check_cargo_toml(path: &Path, text: String) { } } -#[test] -fn check_merge_commits() { - let sh = &Shell::new().unwrap(); - - let bors = cmd!(sh, "git rev-list --merges --author 'bors' HEAD~19..").read().unwrap(); - let all = cmd!(sh, "git rev-list --merges HEAD~19..").read().unwrap(); - if bors != all { - panic!( - " -Merge commits are not allowed in the history. - -When updating a pull-request, please rebase your feature branch -on top of master by running `git rebase master`. If rebase fails, -you can re-apply your changes like this: - - # Just look around to see the current state. - $ git status - $ git log - - # Abort in-progress rebase and merges, if any. - $ git rebase --abort - $ git merge --abort - - # Make the branch point to the latest commit from master, - # while maintaining your local changes uncommited. - $ git reset --soft origin/master - - # Commit all changes in a single batch. - $ git commit -am'My changes' - - # Verify that everything looks alright. - $ git status - $ git log - - # Push the changes. We did a rebase, so we need `--force` option. - # `--force-with-lease` is a more safe (Rusty) version of `--force`. - $ git push --force-with-lease - - # Verify that both local and remote branch point to the same commit. - $ git log - -And don't fear to mess something up during a rebase -- you can -always restore the previous state using `git ref-log`: - -https://github.blog/2015-06-08-how-to-undo-almost-anything-with-git/#redo-after-undo-local -" - ); - } -} - fn deny_clippy(path: &Path, text: &str) { let ignore = &[ // The documentation in string literals may contain anything for its own purposes |
