diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2014-12-17 08:34:08 -0800 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2014-12-17 11:50:25 -0800 |
| commit | bdb1146181e4c320255bec4a93af3d645d522d59 (patch) | |
| tree | 243aa0f52b4ace1723d15a84da9deda982ee3bcd | |
| parent | 823cd7a8d54166dab4c93ab9181071be8f45323e (diff) | |
| parent | ab1bdde536668e752aaf4e9dbfa0acf058d0240b (diff) | |
| download | rust-bdb1146181e4c320255bec4a93af3d645d522d59.tar.gz rust-bdb1146181e4c320255bec4a93af3d645d522d59.zip | |
rollup merge of #19831: luqmana/deriving-where
Fixes #19358.
| -rw-r--r-- | src/libsyntax/ext/deriving/generic/mod.rs | 30 | ||||
| -rw-r--r-- | src/libsyntax/print/pprust.rs | 1 | ||||
| -rw-r--r-- | src/test/run-pass/issue-19358.rs | 29 |
3 files changed, 55 insertions, 5 deletions
diff --git a/src/libsyntax/ext/deriving/generic/mod.rs b/src/libsyntax/ext/deriving/generic/mod.rs index f40be823a1a..b31758e2d2a 100644 --- a/src/libsyntax/ext/deriving/generic/mod.rs +++ b/src/libsyntax/ext/deriving/generic/mod.rs @@ -388,7 +388,7 @@ impl<'a> TraitDef<'a> { methods: Vec<P<ast::Method>>) -> P<ast::Item> { let trait_path = self.path.to_path(cx, self.span, type_ident, generics); - let Generics { mut lifetimes, ty_params, where_clause: _ } = + let Generics { mut lifetimes, ty_params, mut where_clause } = self.generics.to_generics(cx, self.span, type_ident, generics); let mut ty_params = ty_params.into_vec(); @@ -420,13 +420,33 @@ impl<'a> TraitDef<'a> { ty_param.unbound.clone(), None) })); + + // and similarly for where clauses + where_clause.predicates.extend(generics.where_clause.predicates.iter().map(|clause| { + match *clause { + ast::WherePredicate::BoundPredicate(ref wb) => { + ast::WherePredicate::BoundPredicate(ast::WhereBoundPredicate { + id: ast::DUMMY_NODE_ID, + span: self.span, + ident: wb.ident, + bounds: OwnedSlice::from_vec(wb.bounds.iter().map(|b| b.clone()).collect()) + }) + } + ast::WherePredicate::EqPredicate(ref we) => { + ast::WherePredicate::EqPredicate(ast::WhereEqPredicate { + id: ast::DUMMY_NODE_ID, + span: self.span, + path: we.path.clone(), + ty: we.ty.clone() + }) + } + } + })); + let trait_generics = Generics { lifetimes: lifetimes, ty_params: OwnedSlice::from_vec(ty_params), - where_clause: ast::WhereClause { - id: ast::DUMMY_NODE_ID, - predicates: Vec::new(), - }, + where_clause: where_clause }; // Create the reference to the trait. diff --git a/src/libsyntax/print/pprust.rs b/src/libsyntax/print/pprust.rs index b08cf1112fb..18793525e82 100644 --- a/src/libsyntax/print/pprust.rs +++ b/src/libsyntax/print/pprust.rs @@ -1062,6 +1062,7 @@ impl<'a> State<'a> { span: codemap::Span) -> IoResult<()> { try!(self.print_ident(ident)); try!(self.print_generics(generics)); + try!(self.print_where_clause(generics)); if ast_util::struct_def_is_tuple_like(struct_def) { if !struct_def.fields.is_empty() { try!(self.popen()); diff --git a/src/test/run-pass/issue-19358.rs b/src/test/run-pass/issue-19358.rs new file mode 100644 index 00000000000..e4c190f4116 --- /dev/null +++ b/src/test/run-pass/issue-19358.rs @@ -0,0 +1,29 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +trait Trait {} + +#[deriving(Show)] +struct Foo<T: Trait> { + foo: T, +} + +#[deriving(Show)] +struct Bar<T> where T: Trait { + bar: T, +} + +impl Trait for int {} + +fn main() { + let a = Foo { foo: 12i }; + let b = Bar { bar: 12i }; + println!("{} {}", a, b); +} |
