diff options
| author | Tomoaki Kawada <kawada@kmckk.co.jp> | 2022-02-09 14:34:27 +0900 |
|---|---|---|
| committer | Tomoaki Kawada <kawada@kmckk.co.jp> | 2022-02-10 10:21:39 +0900 |
| commit | bdc9508bb6e227979045c5ba3937151635a32ec0 (patch) | |
| tree | 67087b9a331cd372a2b8c62ab0acc5fb6857aa9f | |
| parent | 9a5a961be97f405e751dd2cf966e1cdb80a612c2 (diff) | |
| download | rust-bdc9508bb6e227979045c5ba3937151635a32ec0.tar.gz rust-bdc9508bb6e227979045c5ba3937151635a32ec0.zip | |
kmc-solid: Fix wait queue manipulation errors in the `Condvar` implementation
| -rw-r--r-- | library/std/src/sys/itron/condvar.rs | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/library/std/src/sys/itron/condvar.rs b/library/std/src/sys/itron/condvar.rs index dac4b8abfc4..84b0f4c866a 100644 --- a/library/std/src/sys/itron/condvar.rs +++ b/library/std/src/sys/itron/condvar.rs @@ -15,10 +15,12 @@ unsafe impl Sync for Condvar {} pub type MovableCondvar = Condvar; impl Condvar { + #[inline] pub const fn new() -> Condvar { Condvar { waiters: SpinMutex::new(waiter_queue::WaiterQueue::new()) } } + #[inline] pub unsafe fn init(&mut self) {} pub unsafe fn notify_one(&self) { @@ -206,7 +208,7 @@ mod waiter_queue { if let Some(mut insert_after) = insert_after { // Insert `waiter` after `insert_after` - let insert_before = insert_after.as_ref().prev; + let insert_before = insert_after.as_ref().next; waiter.prev = Some(insert_after); insert_after.as_mut().next = Some(waiter_ptr); @@ -214,6 +216,8 @@ mod waiter_queue { waiter.next = insert_before; if let Some(mut insert_before) = insert_before { insert_before.as_mut().prev = Some(waiter_ptr); + } else { + head.last = waiter_ptr; } } else { // Insert `waiter` to the front @@ -240,11 +244,11 @@ mod waiter_queue { match (waiter.prev, waiter.next) { (Some(mut prev), Some(mut next)) => { prev.as_mut().next = Some(next); - next.as_mut().next = Some(prev); + next.as_mut().prev = Some(prev); } (None, Some(mut next)) => { head.first = next; - next.as_mut().next = None; + next.as_mut().prev = None; } (Some(mut prev), None) => { prev.as_mut().next = None; @@ -271,6 +275,7 @@ mod waiter_queue { unsafe { waiter.as_ref().task != 0 } } + #[inline] pub fn pop_front(&mut self) -> Option<abi::ID> { unsafe { let head = self.head.as_mut()?; |
