diff options
| author | kennytm <kennytm@gmail.com> | 2018-03-20 07:15:32 +0800 |
|---|---|---|
| committer | kennytm <kennytm@gmail.com> | 2018-03-20 11:39:45 +0800 |
| commit | c152e98a75120e39cbd604c1294e4f44910ab9ff (patch) | |
| tree | 17de59e9f07a792768af7f23607a7e195a3b5841 | |
| parent | 7fc81fa781f38734687548c274b3f5474914346d (diff) | |
| parent | a8f59aaef916849155157b11089dd209062eecc4 (diff) | |
| download | rust-c152e98a75120e39cbd604c1294e4f44910ab9ff.tar.gz rust-c152e98a75120e39cbd604c1294e4f44910ab9ff.zip | |
Rollup merge of #49166 - dileepbapat:pr-49133, r=nikomatsakis
#49133 - Reworded the Error message: "`pub` not needed here" message
| -rw-r--r-- | src/librustc_passes/ast_validation.rs | 2 | ||||
| -rw-r--r-- | src/test/ui/error-codes/E0449.stderr | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/librustc_passes/ast_validation.rs b/src/librustc_passes/ast_validation.rs index 4215bf306a4..e5157a071bf 100644 --- a/src/librustc_passes/ast_validation.rs +++ b/src/librustc_passes/ast_validation.rs @@ -67,7 +67,7 @@ impl<'a> AstValidator<'a> { E0449, "unnecessary visibility qualifier"); if vis.node == VisibilityKind::Public { - err.span_label(vis.span, "`pub` not needed here"); + err.span_label(vis.span, "`pub` not permitted here because it's implied"); } if let Some(note) = note { err.note(note); diff --git a/src/test/ui/error-codes/E0449.stderr b/src/test/ui/error-codes/E0449.stderr index 480d8c40022..df3b09ba7c9 100644 --- a/src/test/ui/error-codes/E0449.stderr +++ b/src/test/ui/error-codes/E0449.stderr @@ -2,7 +2,7 @@ error[E0449]: unnecessary visibility qualifier --> $DIR/E0449.rs:17:1 | LL | pub impl Bar {} //~ ERROR E0449 - | ^^^ `pub` not needed here + | ^^^ `pub` not permitted here because it's implied | = note: place qualifiers on individual impl items instead @@ -10,13 +10,13 @@ error[E0449]: unnecessary visibility qualifier --> $DIR/E0449.rs:19:1 | LL | pub impl Foo for Bar { //~ ERROR E0449 - | ^^^ `pub` not needed here + | ^^^ `pub` not permitted here because it's implied error[E0449]: unnecessary visibility qualifier --> $DIR/E0449.rs:20:5 | LL | pub fn foo() {} //~ ERROR E0449 - | ^^^ `pub` not needed here + | ^^^ `pub` not permitted here because it's implied error: aborting due to 3 previous errors |