about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2025-02-06 03:43:58 +0000
committerbors <bors@rust-lang.org>2025-02-06 03:43:58 +0000
commitc753cb9b42e530950204dd0367525cce12811cdd (patch)
treea0665a61160b2fb52b5e17fdcef91d35b5602b2f
parent30865107cb8942ab8eaf9baf8d3aa2a6dec2643f (diff)
parent4f5116e236843492998acfa42381d14db360f2ab (diff)
downloadrust-c753cb9b42e530950204dd0367525cce12811cdd.tar.gz
rust-c753cb9b42e530950204dd0367525cce12811cdd.zip
Auto merge of #136409 - TDecking:mul_hi, r=Mark-Simulacrum
Use `widening_mul` instead of a separate function

A helper function became obsolete after `widening_mul` became available for `u128` values.
-rw-r--r--library/core/src/fmt/num.rs21
1 files changed, 1 insertions, 20 deletions
diff --git a/library/core/src/fmt/num.rs b/library/core/src/fmt/num.rs
index 7166f106b8d..4467b37bd45 100644
--- a/library/core/src/fmt/num.rs
+++ b/library/core/src/fmt/num.rs
@@ -733,28 +733,9 @@ fn udiv_1e19(n: u128) -> (u128, u64) {
     let quot = if n < 1 << 83 {
         ((n >> 19) as u64 / (DIV >> 19)) as u128
     } else {
-        u128_mulhi(n, FACTOR) >> 62
+        n.widening_mul(FACTOR).1 >> 62
     };
 
     let rem = (n - quot * DIV as u128) as u64;
     (quot, rem)
 }
-
-/// Multiply unsigned 128 bit integers, return upper 128 bits of the result
-#[inline]
-fn u128_mulhi(x: u128, y: u128) -> u128 {
-    let x_lo = x as u64;
-    let x_hi = (x >> 64) as u64;
-    let y_lo = y as u64;
-    let y_hi = (y >> 64) as u64;
-
-    // handle possibility of overflow
-    let carry = (x_lo as u128 * y_lo as u128) >> 64;
-    let m = x_lo as u128 * y_hi as u128 + carry;
-    let high1 = m >> 64;
-
-    let m_lo = m as u64;
-    let high2 = (x_hi as u128 * y_lo as u128 + m_lo as u128) >> 64;
-
-    x_hi as u128 * y_hi as u128 + high1 + high2
-}