about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLuqman Aden <me@luqman.ca>2023-05-05 15:13:18 -0700
committerLuqman Aden <me@luqman.ca>2023-05-05 15:13:18 -0700
commitc7c042ad31766a6f70a2c850457f086cf6a03153 (patch)
tree81ee71d80faeb04f017c9239fe5f076e45e419a2
parent7b1eedaae81326567e0439d058546d93f9e7f73a (diff)
downloadrust-c7c042ad31766a6f70a2c850457f086cf6a03153.tar.gz
rust-c7c042ad31766a6f70a2c850457f086cf6a03153.zip
Address review comments.
Remove bitcasts in OperandRef::extract_field; only pointercasts should
be needed.
-rw-r--r--compiler/rustc_codegen_ssa/src/mir/operand.rs6
1 files changed, 0 insertions, 6 deletions
diff --git a/compiler/rustc_codegen_ssa/src/mir/operand.rs b/compiler/rustc_codegen_ssa/src/mir/operand.rs
index 7623daeb96f..9efbb34b515 100644
--- a/compiler/rustc_codegen_ssa/src/mir/operand.rs
+++ b/compiler/rustc_codegen_ssa/src/mir/operand.rs
@@ -247,8 +247,6 @@ impl<'a, 'tcx, V: CodegenObject> OperandRef<'tcx, V> {
                 let ty = bx.cx().immediate_backend_type(field);
                 if bx.type_kind(ty) == TypeKind::Pointer {
                     *llval = bx.pointercast(*llval, ty);
-                } else {
-                    *llval = bx.bitcast(*llval, ty);
                 }
             }
             (OperandValue::Pair(a, b), Abi::ScalarPair(a_abi, b_abi)) => {
@@ -260,13 +258,9 @@ impl<'a, 'tcx, V: CodegenObject> OperandRef<'tcx, V> {
                 let b_ty = bx.cx().scalar_pair_element_backend_type(field, 1, true);
                 if bx.type_kind(a_ty) == TypeKind::Pointer {
                     *a = bx.pointercast(*a, a_ty);
-                } else {
-                    *a = bx.bitcast(*a, a_ty);
                 }
                 if bx.type_kind(b_ty) == TypeKind::Pointer {
                     *b = bx.pointercast(*b, b_ty);
-                } else {
-                    *b = bx.bitcast(*b, b_ty);
                 }
             }
             // Newtype vector of array, e.g. #[repr(simd)] struct S([i32; 4]);