about summary refs log tree commit diff
diff options
context:
space:
mode:
authorYechan Bae <yechan@gatech.edu>2021-03-20 13:42:54 -0400
committerJosh Stone <jistone@redhat.com>2021-04-26 16:46:11 -0700
commitcc4d6d644b6eb9840abf13f8abe882b6e6ee1960 (patch)
tree9d6215a2f7df1a0593c5a81239bff7478a59b59f
parent2fefd9ad07122a4cf1329d52f7c5fe7ccd0893c9 (diff)
Update the comment
(cherry picked from commit 26a62701e42d10c03ce5f2f911e7d5edeefa2f0f)
-rw-r--r--library/alloc/src/str.rs8
1 files changed, 4 insertions, 4 deletions
diff --git a/library/alloc/src/str.rs b/library/alloc/src/str.rs
index 89e6eee925e..73401fcc8a9 100644
--- a/library/alloc/src/str.rs
+++ b/library/alloc/src/str.rs
@@ -163,7 +163,7 @@ where
         })
         .expect("attempt to join into collection with len > usize::MAX");
 
-    // crucial for safety
+    // prepare an uninitialized buffer
     let mut result = Vec::with_capacity(reserved_len);
     debug_assert!(result.capacity() >= reserved_len);
 
@@ -178,9 +178,9 @@ where
         // massive improvements possible (~ x2)
         let remain = specialize_for_lengths!(sep, target, iter; 0, 1, 2, 3, 4);
 
-        // issue #80335: A weird borrow implementation can return different
-        // slices for the length calculation and the actual copy, so
-        // `remain.len()` might be non-zero.
+        // A weird borrow implementation may return different
+        // slices for the length calculation and the actual copy.
+        // Make sure we don't expose uninitialized bytes to the caller.
         let result_len = reserved_len - remain.len();
         result.set_len(result_len);
     }