about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMichael Goulet <michael@errs.io>2023-08-22 09:00:49 -0700
committerGitHub <noreply@github.com>2023-08-22 09:00:49 -0700
commitce0eeee400ba6aafe5c1f5802473afcd490ce0e0 (patch)
tree0561dbb749474cf909b571fb20374ac69c7c1524
parent30d8aa1becc4c06f4326812e4bab997768a86c21 (diff)
parent7012fff9abf6d63625cae368064097966f204bcd (diff)
downloadrust-ce0eeee400ba6aafe5c1f5802473afcd490ce0e0.tar.gz
rust-ce0eeee400ba6aafe5c1f5802473afcd490ce0e0.zip
Rollup merge of #115011 - compiler-errors:warn-on-elided-assoc-ct-lt, r=cjgillot
Warn on elided lifetimes in associated constants (`ELIDED_LIFETIMES_IN_ASSOCIATED_CONSTANT`)

Elided lifetimes in associated constants (in impls) erroneously resolve to fresh lifetime parameters on the impl since #97313. This is not correct behavior (see #38831).

I originally opened #114716 to fix this, but given the time that has passed, the crater results seem pretty bad: https://github.com/rust-lang/rust/pull/114716#issuecomment-1682091952

This PR alternatively implements a lint against this behavior, and I'm hoping to bump this to deny in a few versions.
-rw-r--r--crates/test-utils/src/fixture.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/test-utils/src/fixture.rs b/crates/test-utils/src/fixture.rs
index 75e7a3fec00..3f8b5a08969 100644
--- a/crates/test-utils/src/fixture.rs
+++ b/crates/test-utils/src/fixture.rs
@@ -313,7 +313,7 @@ impl FixtureWithProjectMeta {
 }
 
 impl MiniCore {
-    const RAW_SOURCE: &str = include_str!("./minicore.rs");
+    const RAW_SOURCE: &'static str = include_str!("./minicore.rs");
 
     fn has_flag(&self, flag: &str) -> bool {
         self.activated_flags.iter().any(|it| it == flag)