diff options
| author | Niko Matsakis <niko@alum.mit.edu> | 2018-01-11 06:04:18 -0500 |
|---|---|---|
| committer | Niko Matsakis <niko@alum.mit.edu> | 2018-01-11 06:05:05 -0500 |
| commit | d201e83f710065ded8f27ef8d072319574ac75c8 (patch) | |
| tree | 6129d25d5778b2144c51166a3453328ad1d46059 | |
| parent | bf02c57b16264ce332c799237c58eb8bf1c299c0 (diff) | |
| download | rust-d201e83f710065ded8f27ef8d072319574ac75c8.tar.gz rust-d201e83f710065ded8f27ef8d072319574ac75c8.zip | |
renumber regions in the generator interior
Fixes #47189.
| -rw-r--r-- | src/librustc_mir/borrow_check/nll/renumber.rs | 17 | ||||
| -rw-r--r-- | src/test/ui/nll/generator-distinct-lifetime.rs | 38 |
2 files changed, 54 insertions, 1 deletions
diff --git a/src/librustc_mir/borrow_check/nll/renumber.rs b/src/librustc_mir/borrow_check/nll/renumber.rs index 4aee48b979d..c54acda8a62 100644 --- a/src/librustc_mir/borrow_check/nll/renumber.rs +++ b/src/librustc_mir/borrow_check/nll/renumber.rs @@ -9,7 +9,7 @@ // except according to those terms. use rustc::ty::subst::Substs; -use rustc::ty::{self, ClosureSubsts, Ty, TypeFoldable}; +use rustc::ty::{self, ClosureSubsts, GeneratorInterior, Ty, TypeFoldable}; use rustc::mir::{BasicBlock, Location, Mir, Statement, StatementKind}; use rustc::mir::visit::{MutVisitor, TyContext}; use rustc::infer::{InferCtxt, NLLRegionVariableOrigin}; @@ -90,6 +90,21 @@ impl<'a, 'gcx, 'tcx> MutVisitor<'tcx> for NLLVisitor<'a, 'gcx, 'tcx> { *constant = self.renumber_regions(ty_context, &*constant); } + fn visit_generator_interior(&mut self, + interior: &mut GeneratorInterior<'tcx>, + location: Location) { + debug!( + "visit_generator_interior(interior={:?}, location={:?})", + interior, + location, + ); + + let ty_context = TyContext::Location(location); + *interior = self.renumber_regions(ty_context, interior); + + debug!("visit_generator_interior: interior={:?}", interior); + } + fn visit_closure_substs(&mut self, substs: &mut ClosureSubsts<'tcx>, location: Location) { debug!( "visit_closure_substs(substs={:?}, location={:?})", diff --git a/src/test/ui/nll/generator-distinct-lifetime.rs b/src/test/ui/nll/generator-distinct-lifetime.rs new file mode 100644 index 00000000000..261d1bf85b1 --- /dev/null +++ b/src/test/ui/nll/generator-distinct-lifetime.rs @@ -0,0 +1,38 @@ +// Copyright 2017 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(generators, nll)] + +// Test for issue #47189. Here, both `s` and `t` are live for the +// generator's lifetime, but within the generator they have distinct +// lifetimes. +// +// Currently, we accept this code (with NLL enabled) since `x` is only +// borrowed once at a time -- though whether we should is not entirely +// obvious to me (the borrows are live over a yield, but then they are +// re-borrowing borrowed content, etc). Maybe I just haven't had +// enough coffee today, but I'm not entirely sure at this moment what +// effect a `suspend` should have on existing borrows. -nmatsakis + +fn foo(x: &mut u32) { + move || { + let s = &mut *x; + yield; + *s += 1; + + let t = &mut *x; + yield; + *t += 1; + }; +} + +fn main() { + foo(&mut 0); +} |
