about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAntoni Boucher <bouanto@zoho.com>2022-05-04 21:17:58 -0400
committerAntoni Boucher <bouanto@zoho.com>2022-05-04 21:17:58 -0400
commitd4ab681ebd3b22a071a02aad4005805dd13a41f2 (patch)
tree145f615a48d78ce7a1586832880926a713210aaf
parent41807a30943b2459c8a8e2accfbbead8959490d4 (diff)
downloadrust-d4ab681ebd3b22a071a02aad4005805dd13a41f2.tar.gz
rust-d4ab681ebd3b22a071a02aad4005805dd13a41f2.zip
Add comments
-rw-r--r--src/intrinsic/simd.rs5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/intrinsic/simd.rs b/src/intrinsic/simd.rs
index 6e14f6d021e..6c2834fccf3 100644
--- a/src/intrinsic/simd.rs
+++ b/src/intrinsic/simd.rs
@@ -220,6 +220,7 @@ pub fn generic_simd_intrinsic<'a, 'gcc, 'tcx>(bx: &mut Builder<'a, 'gcc, 'tcx>,
         // NOTE: we cannot cast to an array and assign to its element here because the value might
         // not be an l-value. So, call a builtin to set the element.
         // TODO(antoyo): perhaps we could create a new vector or maybe there's a GIMPLE instruction for that?
+        // TODO(antoyo): don't use target specific builtins here.
         let func_name =
             match in_len {
                 2 => {
@@ -396,6 +397,10 @@ pub fn generic_simd_intrinsic<'a, 'gcc, 'tcx>(bx: &mut Builder<'a, 'gcc, 'tcx>,
                 });
             }
             (Style::Int(_), Style::Float) => {
+                // TODO: add support for internal functions in libgccjit to get access to IFN_VEC_CONVERT which is
+                // doing like __builtin_convertvector?
+                // Or maybe provide convert_vector as an API since it might not easy to get the
+                // types of internal functions.
                 unimplemented!();
             }
             (Style::Float, Style::Int(_)) => {