diff options
| author | Esteban Kuber <esteban@kuber.com.ar> | 2021-09-10 07:30:58 +0000 |
|---|---|---|
| committer | Esteban Kuber <esteban@kuber.com.ar> | 2021-11-23 20:36:19 +0000 |
| commit | d68add9eccf2561380177d07d4e7b31433562a2b (patch) | |
| tree | f678fe56e0858a55e25f6a725a684c49d45fbc04 | |
| parent | 21224e6ee07b917f7996b27f05c57327f806a026 (diff) | |
| download | rust-d68add9eccf2561380177d07d4e7b31433562a2b.tar.gz rust-d68add9eccf2561380177d07d4e7b31433562a2b.zip | |
review comment: plural of emoji is emoji
| -rw-r--r-- | compiler/rustc_interface/src/passes.rs | 2 | ||||
| -rw-r--r-- | compiler/rustc_parse/src/lexer/mod.rs | 2 | ||||
| -rw-r--r-- | compiler/rustc_session/src/parse.rs | 2 | ||||
| -rw-r--r-- | src/test/ui/parser/emoji-identifiers.rs | 12 | ||||
| -rw-r--r-- | src/test/ui/parser/emoji-identifiers.stderr | 12 |
5 files changed, 15 insertions, 15 deletions
diff --git a/compiler/rustc_interface/src/passes.rs b/compiler/rustc_interface/src/passes.rs index 7286209040c..67b5833ca47 100644 --- a/compiler/rustc_interface/src/passes.rs +++ b/compiler/rustc_interface/src/passes.rs @@ -455,7 +455,7 @@ pub fn configure_and_expand( for (ident, spans) in identifiers.drain() { sess.diagnostic().span_err( MultiSpan::from(spans), - &format!("identifiers cannot contain emojis: `{}`", ident), + &format!("identifiers cannot contain emoji: `{}`", ident), ); } }); diff --git a/compiler/rustc_parse/src/lexer/mod.rs b/compiler/rustc_parse/src/lexer/mod.rs index 9403e0af595..1a620968d56 100644 --- a/compiler/rustc_parse/src/lexer/mod.rs +++ b/compiler/rustc_parse/src/lexer/mod.rs @@ -224,7 +224,7 @@ impl<'a> StringReader<'a> { token::Ident(sym, is_raw_ident) } rustc_lexer::TokenKind::InvalidIdent - // Do not recover an identifier with emojis if the codepoint is a confusable + // Do not recover an identifier with emoji if the codepoint is a confusable // with a recoverable substitution token, like `โ`. if UNICODE_ARRAY .iter() diff --git a/compiler/rustc_session/src/parse.rs b/compiler/rustc_session/src/parse.rs index 4e0f6c32e57..d5b520325e5 100644 --- a/compiler/rustc_session/src/parse.rs +++ b/compiler/rustc_session/src/parse.rs @@ -123,7 +123,7 @@ pub struct ParseSess { /// clashing with keywords in new editions. pub raw_identifier_spans: Lock<Vec<Span>>, /// Places where identifiers that contain invalid Unicode codepoints but that look like they - /// should be. Useful to avoid bad tokenization when encountering emojis. We group them to + /// should be. Useful to avoid bad tokenization when encountering emoji. We group them to /// provide a single error per unique incorrect identifier. pub bad_unicode_identifiers: Lock<FxHashMap<Symbol, Vec<Span>>>, source_map: Lrc<SourceMap>, diff --git a/src/test/ui/parser/emoji-identifiers.rs b/src/test/ui/parser/emoji-identifiers.rs index e07e0573e75..ef18939bbb8 100644 --- a/src/test/ui/parser/emoji-identifiers.rs +++ b/src/test/ui/parser/emoji-identifiers.rs @@ -1,16 +1,16 @@ -struct ABig๐ฉโ๐ฉโ๐งโ๐งFamily; //~ ERROR identifiers cannot contain emojis -struct ๐; //~ ERROR identifiers cannot contain emojis +struct ABig๐ฉโ๐ฉโ๐งโ๐งFamily; //~ ERROR identifiers cannot contain emoji +struct ๐; //~ ERROR identifiers cannot contain emoji impl ๐ { - fn full_of_โจ() -> ๐ { //~ ERROR identifiers cannot contain emojis + fn full_of_โจ() -> ๐ { //~ ERROR identifiers cannot contain emoji ๐ } } -fn i_like_to_๐ _a_lot() -> ๐ { //~ ERROR identifiers cannot contain emojis +fn i_like_to_๐ _a_lot() -> ๐ { //~ ERROR identifiers cannot contain emoji ๐::full_ofโจ() //~ ERROR no function or associated item named `full_ofโจ` found for struct `๐` - //~^ ERROR identifiers cannot contain emojis + //~^ ERROR identifiers cannot contain emoji } fn main() { let _ = i_like_to_๐_a_lot() โ 4; //~ ERROR cannot find function `i_like_to_๐_a_lot` in this scope - //~^ ERROR identifiers cannot contain emojis + //~^ ERROR identifiers cannot contain emoji //~| ERROR unknown start of token: \u{2796} } diff --git a/src/test/ui/parser/emoji-identifiers.stderr b/src/test/ui/parser/emoji-identifiers.stderr index a73681d9196..a69a9c542d6 100644 --- a/src/test/ui/parser/emoji-identifiers.stderr +++ b/src/test/ui/parser/emoji-identifiers.stderr @@ -18,25 +18,25 @@ LL | fn i_like_to_๐ _a_lot() -> ๐ { LL | let _ = i_like_to_๐_a_lot() โ 4; | ^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `i_like_to_๐ _a_lot` -error: identifiers cannot contain emojis: `i_like_to_๐_a_lot` +error: identifiers cannot contain emoji: `i_like_to_๐_a_lot` --> $DIR/emoji-identifiers.rs:13:13 | LL | let _ = i_like_to_๐_a_lot() โ 4; | ^^^^^^^^^^^^^^^^^^ -error: identifiers cannot contain emojis: `full_of_โจ` +error: identifiers cannot contain emoji: `full_of_โจ` --> $DIR/emoji-identifiers.rs:4:8 | LL | fn full_of_โจ() -> ๐ { | ^^^^^^^^^^ -error: identifiers cannot contain emojis: `full_ofโจ` +error: identifiers cannot contain emoji: `full_ofโจ` --> $DIR/emoji-identifiers.rs:9:8 | LL | ๐::full_ofโจ() | ^^^^^^^^^ -error: identifiers cannot contain emojis: `๐` +error: identifiers cannot contain emoji: `๐` --> $DIR/emoji-identifiers.rs:2:8 | LL | struct ๐; @@ -53,13 +53,13 @@ LL | fn i_like_to_๐ _a_lot() -> ๐ { LL | ๐::full_ofโจ() | ^^ -error: identifiers cannot contain emojis: `i_like_to_๐ _a_lot` +error: identifiers cannot contain emoji: `i_like_to_๐ _a_lot` --> $DIR/emoji-identifiers.rs:8:4 | LL | fn i_like_to_๐ _a_lot() -> ๐ { | ^^^^^^^^^^^^^^^^^^ -error: identifiers cannot contain emojis: `ABig๐ฉ๐ฉ๐ง๐งFamily` +error: identifiers cannot contain emoji: `ABig๐ฉ๐ฉ๐ง๐งFamily` --> $DIR/emoji-identifiers.rs:1:8 | LL | struct ABig๐ฉ๐ฉ๐ง๐งFamily; |
