diff options
| author | bors <bors@rust-lang.org> | 2023-01-30 17:30:32 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-01-30 17:30:32 +0000 |
| commit | d92070a7b9bf450f3798dca3cad64fd055ffefd8 (patch) | |
| tree | 8aac8bd2f846df8722c709777b781da916a5b89d | |
| parent | 8fb0041f4739dc350e8d74608313bcb7c4c5e20d (diff) | |
| parent | 5ed191de6bf14cdc0aee749fd03fb6dfb32c4926 (diff) | |
| download | rust-d92070a7b9bf450f3798dca3cad64fd055ffefd8.tar.gz rust-d92070a7b9bf450f3798dca3cad64fd055ffefd8.zip | |
Auto merge of #10254 - tylerjw:issue_6929, r=Manishearth
needless_range_loop: improve documentation fixes #6929 changelog: [`needless_range_loop`]: improve documentation
| -rw-r--r-- | clippy_lints/src/loops/mod.rs | 3 | ||||
| -rw-r--r-- | clippy_lints/src/loops/needless_range_loop.rs | 2 | ||||
| -rw-r--r-- | tests/ui/needless_range_loop.stderr | 8 |
3 files changed, 7 insertions, 6 deletions
diff --git a/clippy_lints/src/loops/mod.rs b/clippy_lints/src/loops/mod.rs index 8e52cac4323..610a0233eee 100644 --- a/clippy_lints/src/loops/mod.rs +++ b/clippy_lints/src/loops/mod.rs @@ -61,7 +61,8 @@ declare_clippy_lint! { /// /// ### Why is this bad? /// Just iterating the collection itself makes the intent - /// more clear and is probably faster. + /// more clear and is probably faster because it eliminates + /// the bounds check that is done when indexing. /// /// ### Example /// ```rust diff --git a/clippy_lints/src/loops/needless_range_loop.rs b/clippy_lints/src/loops/needless_range_loop.rs index 3bca93d80aa..d060b6ade24 100644 --- a/clippy_lints/src/loops/needless_range_loop.rs +++ b/clippy_lints/src/loops/needless_range_loop.rs @@ -149,7 +149,7 @@ pub(super) fn check<'tcx>( |diag| { multispan_sugg( diag, - "consider using an iterator", + "consider using an iterator and enumerate()", vec![ (pat.span, format!("({}, <item>)", ident.name)), ( diff --git a/tests/ui/needless_range_loop.stderr b/tests/ui/needless_range_loop.stderr index b31544ec334..cffa19bec3a 100644 --- a/tests/ui/needless_range_loop.stderr +++ b/tests/ui/needless_range_loop.stderr @@ -49,7 +49,7 @@ error: the loop variable `i` is used to index `vec` LL | for i in 0..vec.len() { | ^^^^^^^^^^^^ | -help: consider using an iterator +help: consider using an iterator and enumerate() | LL | for (i, <item>) in vec.iter().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~ @@ -126,7 +126,7 @@ error: the loop variable `i` is used to index `vec` LL | for i in 5..vec.len() { | ^^^^^^^^^^^^ | -help: consider using an iterator +help: consider using an iterator and enumerate() | LL | for (i, <item>) in vec.iter().enumerate().skip(5) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -137,7 +137,7 @@ error: the loop variable `i` is used to index `vec` LL | for i in 5..10 { | ^^^^^ | -help: consider using an iterator +help: consider using an iterator and enumerate() | LL | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -148,7 +148,7 @@ error: the loop variable `i` is used to index `vec` LL | for i in 0..vec.len() { | ^^^^^^^^^^^^ | -help: consider using an iterator +help: consider using an iterator and enumerate() | LL | for (i, <item>) in vec.iter_mut().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~ |