about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAlexis Beingessner <a.beingessner@gmail.com>2014-08-02 14:36:51 -0400
committerAlexis Beingessner <a.beingessner@gmail.com>2014-08-02 14:50:29 -0400
commitd9b2e6b74fb0f8b4320c61d78dc5e07a8d3123b5 (patch)
tree47903ebf09b27be30d6fa023b4bce925ddaf7c4c
parent032d5c1dcd95145d58fe3cce63853855578022a7 (diff)
downloadrust-d9b2e6b74fb0f8b4320c61d78dc5e07a8d3123b5.tar.gz
rust-d9b2e6b74fb0f8b4320c61d78dc5e07a8d3123b5.zip
fix underflow in vec swap_remove
fixes #16200
-rw-r--r--src/libcollections/vec.rs8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/libcollections/vec.rs b/src/libcollections/vec.rs
index a0c92887c43..6618906cf69 100644
--- a/src/libcollections/vec.rs
+++ b/src/libcollections/vec.rs
@@ -964,7 +964,7 @@ impl<T> Vec<T> {
     #[inline]
     pub fn swap_remove(&mut self, index: uint) -> Option<T> {
         let length = self.len();
-        if index < length - 1 {
+        if length > 0 && index < length - 1 {
             self.as_mut_slice().swap(index, length - 1);
         } else if index >= length {
             return None
@@ -2003,6 +2003,12 @@ mod tests {
         let _ = vec[3];
     }
 
+    #[test]
+    fn test_swap_remove_empty() {
+        let mut vec: Vec<uint> = vec!();
+        assert_eq!(vec.swap_remove(0), None);
+    }
+
     #[bench]
     fn bench_new(b: &mut Bencher) {
         b.iter(|| {