diff options
| author | r00ster91 <r00ster91@protonmail.com> | 2021-06-04 14:32:47 +0200 |
|---|---|---|
| committer | r00ster91 <r00ster91@protonmail.com> | 2021-06-04 14:32:47 +0200 |
| commit | dc4ea800b7126e0751ba75eae095cc2a805dc8da (patch) | |
| tree | d79d5b8703f7aeb3fd5b6e78785a51a647f76c63 | |
| parent | 4f3b49fffa13518aa6006762c0eb6851c0c0b2d5 (diff) | |
| download | rust-dc4ea800b7126e0751ba75eae095cc2a805dc8da.tar.gz rust-dc4ea800b7126e0751ba75eae095cc2a805dc8da.zip | |
Replace some std::iter::repeat with str::repeat
| -rw-r--r-- | clippy_lints/src/mem_discriminant.rs | 3 | ||||
| -rw-r--r-- | clippy_lints/src/methods/clone_on_copy.rs | 5 |
2 files changed, 3 insertions, 5 deletions
diff --git a/clippy_lints/src/mem_discriminant.rs b/clippy_lints/src/mem_discriminant.rs index a735c616f6e..aca96e06ef2 100644 --- a/clippy_lints/src/mem_discriminant.rs +++ b/clippy_lints/src/mem_discriminant.rs @@ -7,7 +7,6 @@ use rustc_errors::Applicability; use rustc_hir::{BorrowKind, Expr, ExprKind}; use rustc_lint::{LateContext, LateLintPass}; use rustc_session::{declare_lint_pass, declare_tool_lint}; -use std::iter; declare_clippy_lint! { /// **What it does:** Checks for calls of `mem::discriminant()` on a non-enum type. @@ -67,7 +66,7 @@ impl<'tcx> LateLintPass<'tcx> for MemDiscriminant { } } - let derefs: String = iter::repeat('*').take(derefs_needed).collect(); + let derefs = "*".repeat(derefs_needed); diag.span_suggestion( param.span, "try dereferencing", diff --git a/clippy_lints/src/methods/clone_on_copy.rs b/clippy_lints/src/methods/clone_on_copy.rs index ce2e8fa8b10..1a32af5dc7a 100644 --- a/clippy_lints/src/methods/clone_on_copy.rs +++ b/clippy_lints/src/methods/clone_on_copy.rs @@ -8,7 +8,6 @@ use rustc_hir::{BindingAnnotation, Expr, ExprKind, MatchSource, Node, PatKind}; use rustc_lint::LateContext; use rustc_middle::ty::{self, adjustment::Adjust}; use rustc_span::symbol::{sym, Symbol}; -use std::iter; use super::CLONE_DOUBLE_REF; use super::CLONE_ON_COPY; @@ -54,8 +53,8 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, method_name: Symbol, ty = inner; n += 1; } - let refs: String = iter::repeat('&').take(n + 1).collect(); - let derefs: String = iter::repeat('*').take(n).collect(); + let refs = "&".repeat(n + 1); + let derefs = "*".repeat(n); let explicit = format!("<{}{}>::clone({})", refs, ty, snip); diag.span_suggestion( expr.span, |