about summary refs log tree commit diff
diff options
context:
space:
mode:
authorfrancorbacho <francorbacho@proton.me>2023-10-04 17:46:48 +0200
committerfrancorbacho <francorbacho@proton.me>2023-10-05 16:09:57 +0200
commitdc75c99226f948c3459f9970dbd6fe0b5d2bbef2 (patch)
tree64ea210c3034ecab03db2d558141cbd68b58ca9a
parente1c18f4d9de902ad615035bfed4e173d72f7ff09 (diff)
downloadrust-dc75c99226f948c3459f9970dbd6fe0b5d2bbef2.tar.gz
rust-dc75c99226f948c3459f9970dbd6fe0b5d2bbef2.zip
Remove unused variable
-rw-r--r--compiler/rustc_builtin_macros/src/format.rs9
1 files changed, 4 insertions, 5 deletions
diff --git a/compiler/rustc_builtin_macros/src/format.rs b/compiler/rustc_builtin_macros/src/format.rs
index 2d91de105cd..cdd5e7225bb 100644
--- a/compiler/rustc_builtin_macros/src/format.rs
+++ b/compiler/rustc_builtin_macros/src/format.rs
@@ -720,7 +720,6 @@ fn report_redundant_format_arguments(
     let mut fmt_arg_indices = vec![];
     let mut args_spans = vec![];
     let mut fmt_spans = vec![];
-    let mut bindings = vec![];
 
     for (i, unnamed_arg) in args.unnamed_args().iter().enumerate().rev() {
         let Some(ty) = unnamed_arg.expr.to_ty() else { continue };
@@ -734,17 +733,17 @@ fn report_redundant_format_arguments(
         let matching_placeholders = placeholders
             .iter()
             .filter(|(_, inline_binding)| argument_binding == *inline_binding)
+            .map(|(span, _)| span)
             .collect::<Vec<_>>();
 
         if !matching_placeholders.is_empty() {
             fmt_arg_indices.push(i);
             args_spans.push(unnamed_arg.expr.span);
-            for (span, binding) in &matching_placeholders {
-                if fmt_spans.contains(span) {
+            for span in &matching_placeholders {
+                if fmt_spans.contains(*span) {
                     continue;
                 }
-                fmt_spans.push(*span);
-                bindings.push(binding);
+                fmt_spans.push(**span);
             }
         }
     }