diff options
| author | Matthias Krüger <476013+matthiaskrgr@users.noreply.github.com> | 2025-03-12 17:59:09 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-03-12 17:59:09 +0100 |
| commit | de7e5e96be978e5f76f2427351c4ce4a43820380 (patch) | |
| tree | eee21e94309748cc4b4dee1ad63e24836f09794f | |
| parent | d93ef397ce4522be2e90585f2a81142728596dd7 (diff) | |
| parent | 9882eca151a4c1c604597acd98072babb9e6ffcf (diff) | |
| download | rust-de7e5e96be978e5f76f2427351c4ce4a43820380.tar.gz rust-de7e5e96be978e5f76f2427351c4ce4a43820380.zip | |
Rollup merge of #138345 - oli-obk:autodiff-cleanup, r=compiler-errors
Some autodiff cleanups cc ````@ZuseZ4```` just some things I noticed
| -rw-r--r-- | compiler/rustc_monomorphize/src/partitioning/autodiff.rs | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/compiler/rustc_monomorphize/src/partitioning/autodiff.rs b/compiler/rustc_monomorphize/src/partitioning/autodiff.rs index 0c855508434..ebe0b258c1b 100644 --- a/compiler/rustc_monomorphize/src/partitioning/autodiff.rs +++ b/compiler/rustc_monomorphize/src/partitioning/autodiff.rs @@ -12,21 +12,15 @@ fn adjust_activity_to_abi<'tcx>(tcx: TyCtxt<'tcx>, fn_ty: Ty<'tcx>, da: &mut Vec if !matches!(fn_ty.kind(), ty::FnDef(..)) { bug!("expected fn def for autodiff, got {:?}", fn_ty); } - let fnc_binder: ty::Binder<'_, ty::FnSig<'_>> = fn_ty.fn_sig(tcx); - // If rustc compiles the unmodified primal, we know that this copy of the function - // also has correct lifetimes. We know that Enzyme won't free the shadow too early - // (or actually at all), so let's strip lifetimes when computing the layout. - let x = tcx.instantiate_bound_regions_with_erased(fnc_binder); + // We don't actually pass the types back into the type system. + // All we do is decide how to handle the arguments. + let sig = fn_ty.fn_sig(tcx).skip_binder(); + let mut new_activities = vec![]; let mut new_positions = vec![]; - for (i, ty) in x.inputs().iter().enumerate() { + for (i, ty) in sig.inputs().iter().enumerate() { if let Some(inner_ty) = ty.builtin_deref(true) { - if ty.is_fn_ptr() { - // FIXME(ZuseZ4): add a nicer error, or just figure out how to support them, - // since Enzyme itself can handle them. - tcx.dcx().err("function pointers are currently not supported in autodiff"); - } if inner_ty.is_slice() { // We know that the length will be passed as extra arg. if !da.is_empty() { |
