about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-02-06 13:38:36 +0000
committerbors <bors@rust-lang.org>2021-02-06 13:38:36 +0000
commitdfb34c085ff5421ececed8e42b8a8a6fea18c0b7 (patch)
tree42dc8fbdbc2082e84170991dc62769fca8b9aa6f
parenta507c27660d05f37307369d30bee9e82ce3a11e1 (diff)
parent93daf27a4006f4d06f8b1653c23783ec52e93a75 (diff)
downloadrust-dfb34c085ff5421ececed8e42b8a8a6fea18c0b7.tar.gz
rust-dfb34c085ff5421ececed8e42b8a8a6fea18c0b7.zip
Auto merge of #6684 - matthiaskrgr:versiontest_dont_break_upstream, r=flip1995
tests: ignore check_that_clippy_has_the_same_major_version_as_rustc()inside the rustc repo

Do not check if clippy version matches rustc version when runnning tests inside the rustc repo.
This makes sure that upstream rustc maintainers do not have to deal with our test failing/mismatching versions
when the rustc version bump is happening.
cc #6683

We already do the "don't run inside the rustc-repo" workaround for the dogfood test:
https://github.com/rust-lang/rust-clippy/blob/a507c27660d05f37307369d30bee9e82ce3a11e1/tests/dogfood.rs#L16

changelog: None
-rw-r--r--tests/versioncheck.rs6
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/versioncheck.rs b/tests/versioncheck.rs
index 76b6126c76c..bc5ed0816cc 100644
--- a/tests/versioncheck.rs
+++ b/tests/versioncheck.rs
@@ -23,6 +23,12 @@ fn check_that_clippy_lints_has_the_same_version_as_clippy() {
 
 #[test]
 fn check_that_clippy_has_the_same_major_version_as_rustc() {
+    // do not run this test inside the upstream rustc repo:
+    // https://github.com/rust-lang/rust-clippy/issues/6683
+    if option_env!("RUSTC_TEST_SUITE").is_some() {
+        return;
+    }
+
     let clippy_version = rustc_tools_util::get_version_info!();
     let clippy_major = clippy_version.major;
     let clippy_minor = clippy_version.minor;