about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-08-15 06:16:41 +0000
committerbors <bors@rust-lang.org>2015-08-15 06:16:41 +0000
commite859498d1ca45f2719542f505eb0ba8b944e5668 (patch)
treefb940178e46797d70ff284510d3581268849912e
parent1e1b7f30228782ebf6168a5e20e63cdd7b9763ff (diff)
parent59f8e3238a38afe350bf8cdc119d7315bf9b5f6c (diff)
downloadrust-e859498d1ca45f2719542f505eb0ba8b944e5668.tar.gz
rust-e859498d1ca45f2719542f505eb0ba8b944e5668.zip
Auto merge of #27841 - jonas-schievink:still-repeating-span, r=alexcrichton
Current behaviour demo: http://is.gd/l3FEgo
(The span is printed at the start of the source code)

This patch moves the span to the use of `$i` in the macro rhs (as the code comment already claims)
-rw-r--r--src/libsyntax/ext/tt/transcribe.rs2
-rw-r--r--src/test/parse-fail/macro-repeat.rs19
2 files changed, 20 insertions, 1 deletions
diff --git a/src/libsyntax/ext/tt/transcribe.rs b/src/libsyntax/ext/tt/transcribe.rs
index 0ca755c97b1..b07bd099638 100644
--- a/src/libsyntax/ext/tt/transcribe.rs
+++ b/src/libsyntax/ext/tt/transcribe.rs
@@ -305,7 +305,7 @@ pub fn tt_next_token(r: &mut TtReader) -> TokenAndSpan {
                             }
                             MatchedSeq(..) => {
                                 panic!(r.sp_diag.span_fatal(
-                                    r.cur_span, /* blame the macro writer */
+                                    sp, /* blame the macro writer */
                                     &format!("variable '{}' is still repeating at this depth",
                                             ident)));
                             }
diff --git a/src/test/parse-fail/macro-repeat.rs b/src/test/parse-fail/macro-repeat.rs
new file mode 100644
index 00000000000..3abadd885ac
--- /dev/null
+++ b/src/test/parse-fail/macro-repeat.rs
@@ -0,0 +1,19 @@
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+macro_rules! mac {
+    ( $($v:tt)* ) => (
+        $v  //~ ERROR still repeating at this depth
+    )
+}
+
+fn main() {
+    mac!(0);
+}