diff options
| author | Bastian Kauschke <bastian_kauschke@hotmail.de> | 2020-07-18 19:22:12 +0200 |
|---|---|---|
| committer | Bastian Kauschke <bastian_kauschke@hotmail.de> | 2020-07-18 19:23:35 +0200 |
| commit | e8d16fdf9f95e4110df53650779be842b6749f60 (patch) | |
| tree | a468f530cd017746af8d5f5231f6b1a5f9ad25fa | |
| parent | 7e11379f3b4c376fbb9a6c4d44f3286ccc28d149 (diff) | |
| download | rust-e8d16fdf9f95e4110df53650779be842b6749f60.tar.gz rust-e8d16fdf9f95e4110df53650779be842b6749f60.zip | |
add note to `opt_const_param_of`
| -rw-r--r-- | src/librustc_middle/query/mod.rs | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/librustc_middle/query/mod.rs b/src/librustc_middle/query/mod.rs index 40ff25cf3b1..06136a82e7b 100644 --- a/src/librustc_middle/query/mod.rs +++ b/src/librustc_middle/query/mod.rs @@ -103,9 +103,13 @@ rustc_queries! { /// // ^ While calling `opt_const_param_of` for other bodies returns `None`. /// } /// ``` + // It looks like caching this query on disk actually slightly + // worsened performance in #74376. + // + // Once const generics are more prevalently used, we might want to + // consider only caching calls returning `Some`. query opt_const_param_of(key: LocalDefId) -> Option<DefId> { desc { |tcx| "computing the optional const parameter of `{}`", tcx.def_path_str(key.to_def_id()) } - // FIXME(#74113): consider storing this query on disk. } /// Records the type of every item. |