diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2023-04-26 18:51:40 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-26 18:51:40 +0200 |
| commit | ea8bd06b56bd34098b315f811d911a1d4ad9cb5d (patch) | |
| tree | ccec331f73f956a108ae1b0b0ee64a490e62ea8f | |
| parent | 309496cf29cba30985a55cd5a07872587cfa9da0 (diff) | |
| parent | b311ec02cc4e736c145de827504567086358094f (diff) | |
| download | rust-ea8bd06b56bd34098b315f811d911a1d4ad9cb5d.tar.gz rust-ea8bd06b56bd34098b315f811d911a1d4ad9cb5d.zip | |
Rollup merge of #109444 - WaffleLapkin:undeprecate_todos, r=jyn514
Change tidy error message for TODOs Blocked on #109440 (first few commits are from where) IMO "deprecated" doesn't really explain anything, I've tried to highlight the actual reason we error on TODOs. The message is not at all perfect, maybe someone has ideas how to phrase it better?
| -rw-r--r-- | src/tools/tidy/src/style.rs | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/tools/tidy/src/style.rs b/src/tools/tidy/src/style.rs index a2012db903a..5f388ee47bb 100644 --- a/src/tools/tidy/src/style.rs +++ b/src/tools/tidy/src/style.rs @@ -385,10 +385,12 @@ pub fn check(path: &Path, bad: &mut bool) { } if filename != "style.rs" { if trimmed.contains("TODO") { - err("TODO is deprecated; use FIXME") + err( + "TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME", + ) } if trimmed.contains("//") && trimmed.contains(" XXX") { - err("XXX is deprecated; use FIXME") + err("Instead of XXX use FIXME") } if any_problematic_line { for s in problematic_consts_strings.iter() { |
