diff options
| author | Aleksey Kladov <aleksey.kladov@gmail.com> | 2021-01-07 19:27:47 +0300 |
|---|---|---|
| committer | Aleksey Kladov <aleksey.kladov@gmail.com> | 2021-01-07 19:27:47 +0300 |
| commit | eb710a63ca94409dd410ebde57923bcaf48f2975 (patch) | |
| tree | 47e6c76c1c4580bf92bf721d98b19b613cf575a1 | |
| parent | b821264f861be959709aa0e7e87b4c5e1ce335b5 (diff) | |
| download | rust-eb710a63ca94409dd410ebde57923bcaf48f2975.tar.gz rust-eb710a63ca94409dd410ebde57923bcaf48f2975.zip | |
Document `std::ops` style
| -rw-r--r-- | docs/dev/style.md | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/docs/dev/style.md b/docs/dev/style.md index d91a9108e1a..be2c7784730 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md @@ -435,7 +435,7 @@ Avoid local `use MyEnum::*` imports. Prefer `use crate::foo::bar` to `use super::bar`. -When implementing `Debug` or `Display`, import `std::fmt`: +When implementing traits from `std::fmt` or `std::ops`, import the module: ```rust // Good @@ -449,6 +449,14 @@ impl fmt::Display for RenameError { impl std::fmt::Display for RenameError { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { .. } } + +// Not as good +use std::ops::Deref; + +impl Deref for Widget { + type Target = str; + fn deref(&self) -> &str { .. } +} ``` ## Order of Items |
