about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthias Krüger <476013+matthiaskrgr@users.noreply.github.com>2025-04-15 21:16:06 +0200
committerGitHub <noreply@github.com>2025-04-15 21:16:06 +0200
commitebaef469b0392c35badfa372279bb00211f560b8 (patch)
tree0298e0f294c5dfb8501ba939d4c5d25a4643a276
parent2e363ce1df37c0d0ba4018567a0135d1bf119912 (diff)
parent043c5ff98262409a9c338001200c4cf2a66e72c8 (diff)
downloadrust-ebaef469b0392c35badfa372279bb00211f560b8.tar.gz
rust-ebaef469b0392c35badfa372279bb00211f560b8.zip
Rollup merge of #139877 - joshtriplett:take-care, r=dtolnay
Add warning comment to `Take::get_ref` and `Chain::get_ref`

The methods `Take::get_mut` and `Chain::get_mut` include comments
warning about modifying the I/O state of the underlying reader. However,
many readers (e.g. `File`) allow I/O using a shared reference (e.g.
`&File`). So, add the same caveat to the `get_ref` methods.
-rw-r--r--library/std/src/io/mod.rs8
1 files changed, 8 insertions, 0 deletions
diff --git a/library/std/src/io/mod.rs b/library/std/src/io/mod.rs
index b6545eada86..5242261cf93 100644
--- a/library/std/src/io/mod.rs
+++ b/library/std/src/io/mod.rs
@@ -2658,6 +2658,10 @@ impl<T, U> Chain<T, U> {
 
     /// Gets references to the underlying readers in this `Chain`.
     ///
+    /// Care should be taken to avoid modifying the internal I/O state of the
+    /// underlying readers as doing so may corrupt the internal state of this
+    /// `Chain`.
+    ///
     /// # Examples
     ///
     /// ```no_run
@@ -2915,6 +2919,10 @@ impl<T> Take<T> {
 
     /// Gets a reference to the underlying reader.
     ///
+    /// Care should be taken to avoid modifying the internal I/O state of the
+    /// underlying reader as doing so may corrupt the internal limit of this
+    /// `Take`.
+    ///
     /// # Examples
     ///
     /// ```no_run