diff options
| author | David Wood <david.wood@huawei.com> | 2024-02-14 14:17:27 +0000 |
|---|---|---|
| committer | David Wood <david.wood@huawei.com> | 2024-02-15 10:34:41 +0000 |
| commit | ec5328b3d9aa08986abd3237b40c0bf74b08bc2b (patch) | |
| tree | 7318a581e2d3d59e6ce58d4537d532549207a6e7 | |
| parent | 5a12a899926cb2ead9bf7b18690e99fa21b51e55 (diff) | |
| download | rust-ec5328b3d9aa08986abd3237b40c0bf74b08bc2b.tar.gz rust-ec5328b3d9aa08986abd3237b40c0bf74b08bc2b.zip | |
errors: only eagerly translate subdiagnostics
Subdiagnostics don't need to be lazily translated, they can always be eagerly translated. Eager translation is slightly more complex as we need to have a `DiagCtxt` available to perform the translation, which involves slightly more threading of that context. This slight increase in complexity should enable later simplifications - like passing `DiagCtxt` into `AddToDiagnostic` and moving Fluent messages into the diagnostic structs rather than having them in separate files (working on that was what led to this change). Signed-off-by: David Wood <david@davidtw.co>
| -rw-r--r-- | src/errors.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/errors.rs b/src/errors.rs index cc0fbe46dcc..79eb4406b8a 100644 --- a/src/errors.rs +++ b/src/errors.rs @@ -122,7 +122,7 @@ impl<G: EmissionGuarantee> IntoDiagnostic<'_, G> for TargetFeatureDisableOrEnabl diag.span(span); }; if let Some(missing_features) = self.missing_features { - diag.subdiagnostic(missing_features); + diag.subdiagnostic(dcx, missing_features); } diag.arg("features", self.features.join(", ")); diag |