about summary refs log tree commit diff
diff options
context:
space:
mode:
authorYoshiki Matsuda <myskjp@gmail.com>2022-05-30 00:49:26 +0900
committerYoshiki Matsuda <myskjp@gmail.com>2022-07-02 22:54:37 +0900
commitec64b4c90ed7b277b9946e6d10bea25befe13488 (patch)
tree3ad8830755d5e6738291f237bf975490014cedeb
parent03de5c4a14e58f45fb411b9369f98508473416ae (diff)
downloadrust-ec64b4c90ed7b277b9946e6d10bea25befe13488.tar.gz
rust-ec64b4c90ed7b277b9946e6d10bea25befe13488.zip
add a comment about the drop order for EncodedMetadata
-rw-r--r--compiler/rustc_metadata/src/rmeta/encoder.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/compiler/rustc_metadata/src/rmeta/encoder.rs b/compiler/rustc_metadata/src/rmeta/encoder.rs
index 3ae4fbb70a5..b58f95b058b 100644
--- a/compiler/rustc_metadata/src/rmeta/encoder.rs
+++ b/compiler/rustc_metadata/src/rmeta/encoder.rs
@@ -2144,6 +2144,7 @@ fn prefetch_mir(tcx: TyCtxt<'_>) {
 // generated regardless of trailing bytes that end up in it.
 
 pub struct EncodedMetadata {
+    // The declaration order matters because `mmap` should be dropped before `_temp_dir`.
     mmap: Option<Mmap>,
     // We need to carry MaybeTempDir to avoid deleting the temporary
     // directory while accessing the Mmap.