about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2014-08-18 06:01:08 +0000
committerbors <bors@rust-lang.org>2014-08-18 06:01:08 +0000
commitef439ddce0d735bf6ae6f583a76b36a22951ab28 (patch)
tree2ee1063dc7ca05b75297ea5d50b8e8774b5742db
parent1824973a139443b15e2c093b3e316169f2792cb3 (diff)
parent480674694e364e94e6ef35520113a45f54b2fe6f (diff)
downloadrust-ef439ddce0d735bf6ae6f583a76b36a22951ab28.tar.gz
rust-ef439ddce0d735bf6ae6f583a76b36a22951ab28.zip
auto merge of #16450 : klutzy/rust/win-fixme-cleanup, r=alexcrichton
First commit enables regex test on Windows. It was not working at some point (#13725), but it works now.

Second commit removes various FIXMEs regarding #13793, since upstream bug has been fixed.
-rw-r--r--src/libregex/lib.rs3
-rw-r--r--src/test/bench/shootout-regex-dna.rs2
-rw-r--r--src/test/compile-fail-fulldeps/syntax-extension-regex-invalid.rs2
-rw-r--r--src/test/compile-fail-fulldeps/syntax-extension-regex-unused-static.rs2
-rw-r--r--src/test/compile-fail-fulldeps/syntax-extension-regex-unused.rs2
-rw-r--r--src/test/run-make/no-intermediate-extras/foo.rs5
-rw-r--r--src/test/run-pass/issue-14393.rs2
-rw-r--r--src/test/run-pass/test-runner-hides-main.rs1
8 files changed, 1 insertions, 18 deletions
diff --git a/src/libregex/lib.rs b/src/libregex/lib.rs
index fae3e598680..1d25a0c31d8 100644
--- a/src/libregex/lib.rs
+++ b/src/libregex/lib.rs
@@ -395,8 +395,7 @@ mod parse;
 mod re;
 mod vm;
 
-// FIXME(#13725) windows needs fixing.
-#[cfg(test, not(windows))]
+#[cfg(test)]
 mod test;
 
 /// The `native` module exists to support the `regex!` macro. Do not use.
diff --git a/src/test/bench/shootout-regex-dna.rs b/src/test/bench/shootout-regex-dna.rs
index 606f075d96d..433d62c7e96 100644
--- a/src/test/bench/shootout-regex-dna.rs
+++ b/src/test/bench/shootout-regex-dna.rs
@@ -38,8 +38,6 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 // OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// FIXME(#13725) windows needs fixing.
-// ignore-windows
 // ignore-stage1
 // ignore-cross-compile #12102
 
diff --git a/src/test/compile-fail-fulldeps/syntax-extension-regex-invalid.rs b/src/test/compile-fail-fulldeps/syntax-extension-regex-invalid.rs
index 64ef1abe7de..32e0bff1991 100644
--- a/src/test/compile-fail-fulldeps/syntax-extension-regex-invalid.rs
+++ b/src/test/compile-fail-fulldeps/syntax-extension-regex-invalid.rs
@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// FIXME(#13725) windows needs fixing.
-// ignore-windows
 // ignore-stage1
 
 #![feature(phase)]
diff --git a/src/test/compile-fail-fulldeps/syntax-extension-regex-unused-static.rs b/src/test/compile-fail-fulldeps/syntax-extension-regex-unused-static.rs
index 8d859c3f7ba..d7135bc5c91 100644
--- a/src/test/compile-fail-fulldeps/syntax-extension-regex-unused-static.rs
+++ b/src/test/compile-fail-fulldeps/syntax-extension-regex-unused-static.rs
@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// FIXME(#13725) windows needs fixing.
-// ignore-windows
 // ignore-stage1
 
 #![feature(phase)]
diff --git a/src/test/compile-fail-fulldeps/syntax-extension-regex-unused.rs b/src/test/compile-fail-fulldeps/syntax-extension-regex-unused.rs
index 304ad7423b1..c17f3c6da50 100644
--- a/src/test/compile-fail-fulldeps/syntax-extension-regex-unused.rs
+++ b/src/test/compile-fail-fulldeps/syntax-extension-regex-unused.rs
@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// FIXME(#13725) windows needs fixing.
-// ignore-windows
 // ignore-stage1
 
 #![feature(phase)]
diff --git a/src/test/run-make/no-intermediate-extras/foo.rs b/src/test/run-make/no-intermediate-extras/foo.rs
index 60a7f067476..e6c76025738 100644
--- a/src/test/run-make/no-intermediate-extras/foo.rs
+++ b/src/test/run-make/no-intermediate-extras/foo.rs
@@ -7,8 +7,3 @@
 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
-
-// FIXME #13793
-#[test]
-fn test_dummy() {
-}
diff --git a/src/test/run-pass/issue-14393.rs b/src/test/run-pass/issue-14393.rs
index 99af544e786..e97021b4869 100644
--- a/src/test/run-pass/issue-14393.rs
+++ b/src/test/run-pass/issue-14393.rs
@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-windows: FIXME #13793
-
 fn main() {
     match ("", 1u) {
         (_, 42u) => (),
diff --git a/src/test/run-pass/test-runner-hides-main.rs b/src/test/run-pass/test-runner-hides-main.rs
index 64b914a7438..9b658ee1dae 100644
--- a/src/test/run-pass/test-runner-hides-main.rs
+++ b/src/test/run-pass/test-runner-hides-main.rs
@@ -9,7 +9,6 @@
 // except according to those terms.
 
 // compile-flags:--test
-// ignore-windows #10872
 // ignore-pretty: does not work well with `--test`
 
 // Building as a test runner means that a synthetic main will be run,