about summary refs log tree commit diff
diff options
context:
space:
mode:
authorChris Denton <chris@chrisdenton.dev>2024-08-09 21:21:43 +0000
committerChris Denton <chris@chrisdenton.dev>2024-08-09 21:21:43 +0000
commitef90df69044df03daece7ad367792a6424420f90 (patch)
tree1662ec9f667e697944e3e4783c04724f1fc00041
parent2cc029edf5239e1754f2cde3de4f69c45c134550 (diff)
downloadrust-ef90df69044df03daece7ad367792a6424420f90.tar.gz
rust-ef90df69044df03daece7ad367792a6424420f90.zip
Update reason why fmt-write-bloat ignores windows
-rw-r--r--tests/run-make/fmt-write-bloat/rmake.rs7
1 files changed, 5 insertions, 2 deletions
diff --git a/tests/run-make/fmt-write-bloat/rmake.rs b/tests/run-make/fmt-write-bloat/rmake.rs
index 4ae226ec0e2..6875ef9ddc0 100644
--- a/tests/run-make/fmt-write-bloat/rmake.rs
+++ b/tests/run-make/fmt-write-bloat/rmake.rs
@@ -15,9 +15,12 @@
 //! `NO_DEBUG_ASSERTIONS=1`). If debug assertions are disabled, then we can check for the absence of
 //! additional `usize` formatting and padding related symbols.
 
-// Reason: This test is `ignore-windows` because the `no_std` test (using `#[link(name = "c")])`
-// doesn't link on windows.
 //@ ignore-windows
+// Reason:
+// - MSVC targets really need to parse the .pdb file (aka the debug information).
+//   On Windows there's an API for that (dbghelp) which maybe we can use
+// - MinGW targets have a lot of symbols included in their runtime which we can't avoid.
+//   We would need to make the symbols we're looking for more specific for this test to work.
 //@ ignore-cross-compile
 
 use run_make_support::env::no_debug_assertions;