about summary refs log tree commit diff
diff options
context:
space:
mode:
authorManish Goregaokar <manishsmail@gmail.com>2015-04-24 09:44:17 +0530
committerManish Goregaokar <manishsmail@gmail.com>2015-04-24 19:21:14 +0530
commitf1db259804535076bff7f8fcdb14f782cc4486b4 (patch)
treee168e2961e01debb8aa0abe664d0c524d1dcce1f
parentfb0f344ae2c913ba5fb796a9ad86161efcedd58c (diff)
parent4047a7c29f5e4481ba6056cadf4a1157e9d16c8f (diff)
downloadrust-f1db259804535076bff7f8fcdb14f782cc4486b4.tar.gz
rust-f1db259804535076bff7f8fcdb14f782cc4486b4.zip
Rollup merge of #24706 - tamird:remove-DST-comment, r=alexcrichton
`ToCStr` was removed with `old_io` and the current method `as_os_str`
is inherent to `Path`, meaning there is no suitable trait bound that
could be used here.

r? @alexcrichton
-rw-r--r--src/libstd/dynamic_lib.rs8
1 files changed, 0 insertions, 8 deletions
diff --git a/src/libstd/dynamic_lib.rs b/src/libstd/dynamic_lib.rs
index 8ca462f5a38..d0f990eaf78 100644
--- a/src/libstd/dynamic_lib.rs
+++ b/src/libstd/dynamic_lib.rs
@@ -40,14 +40,6 @@ impl Drop for DynamicLibrary {
 }
 
 impl DynamicLibrary {
-    // FIXME (#12938): Until DST lands, we cannot decompose &str into
-    // & and str, so we cannot usefully take ToCStr arguments by
-    // reference (without forcing an additional & around &str). So we
-    // are instead temporarily adding an instance for &Path, so that
-    // we can take ToCStr as owned. When DST lands, the &Path instance
-    // should be removed, and arguments bound by ToCStr should be
-    // passed by reference. (Here: in the `open` method.)
-
     /// Lazily open a dynamic library. When passed None it gives a
     /// handle to the calling process
     pub fn open(filename: Option<&Path>) -> Result<DynamicLibrary, String> {