diff options
| author | Jonas Schievink <jonas.schievink@ferrous-systems.com> | 2022-04-14 13:00:08 +0200 |
|---|---|---|
| committer | Jonas Schievink <jonas.schievink@ferrous-systems.com> | 2022-04-14 13:00:08 +0200 |
| commit | f5403aef9686c8d5337ac2aae99b2da54646143c (patch) | |
| tree | 6a3ab90e2183356f329a2a57487d59b90307edba | |
| parent | 5620d25972b5aaf045ac53078b992c903742ca20 (diff) | |
| download | rust-f5403aef9686c8d5337ac2aae99b2da54646143c.tar.gz rust-f5403aef9686c8d5337ac2aae99b2da54646143c.zip | |
simplify
| -rw-r--r-- | crates/ide_assists/src/handlers/expand_glob_import.rs | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/crates/ide_assists/src/handlers/expand_glob_import.rs b/crates/ide_assists/src/handlers/expand_glob_import.rs index 3566b1be895..4de4def2e86 100644 --- a/crates/ide_assists/src/handlers/expand_glob_import.rs +++ b/crates/ide_assists/src/handlers/expand_glob_import.rs @@ -52,7 +52,7 @@ pub(crate) fn expand_glob_import(acc: &mut Assists, ctx: &AssistContext) -> Opti let current_scope = ctx.sema.scope(&star.parent()?)?; let current_module = current_scope.module(); - let refs_in_target = find_refs_in_mod(ctx, target_module, Some(current_module))?; + let refs_in_target = find_refs_in_mod(ctx, target_module, current_module)?; let imported_defs = find_imported_defs(ctx, star)?; let target = parent.either(|n| n.syntax().clone(), |n| n.syntax().clone()); @@ -168,18 +168,12 @@ impl Refs { } } -fn find_refs_in_mod( - ctx: &AssistContext, - module: Module, - visible_from: Option<Module>, -) -> Option<Refs> { - if let Some(from) = visible_from { - if !is_mod_visible_from(ctx, module, from) { - return None; - } +fn find_refs_in_mod(ctx: &AssistContext, module: Module, visible_from: Module) -> Option<Refs> { + if !is_mod_visible_from(ctx, module, visible_from) { + return None; } - let module_scope = module.scope(ctx.db(), visible_from); + let module_scope = module.scope(ctx.db(), Some(visible_from)); let refs = module_scope.into_iter().filter_map(|(n, d)| Ref::from_scope_def(n, d)).collect(); Some(Refs(refs)) } |
