about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMichael Howell <michael@notriddle.com>2022-06-28 15:06:48 -0700
committerMichael Howell <michael@notriddle.com>2022-06-28 17:29:55 -0700
commitf5f42a8cba22fe1616b33cbedf2adc9bf01056b0 (patch)
tree4b1f40c3fc5e56b1287294476cd786993775d00b
parentcb8a7388fa0106793c3ea709528fa1408c7cf87b (diff)
downloadrust-f5f42a8cba22fe1616b33cbedf2adc9bf01056b0.tar.gz
rust-f5f42a8cba22fe1616b33cbedf2adc9bf01056b0.zip
rustdoc: make keyboard commands work when checkboxes are selected
-rw-r--r--src/librustdoc/html/static/js/main.js3
-rw-r--r--src/test/rustdoc-gui/settings.goml1
2 files changed, 3 insertions, 1 deletions
diff --git a/src/librustdoc/html/static/js/main.js b/src/librustdoc/html/static/js/main.js
index 789e7d298fa..c33e2727744 100644
--- a/src/librustdoc/html/static/js/main.js
+++ b/src/librustdoc/html/static/js/main.js
@@ -419,7 +419,8 @@ function loadCss(cssFileName) {
             return;
         }
 
-        if (document.activeElement.tagName === "INPUT") {
+        if (document.activeElement.tagName === "INPUT" &&
+            document.activeElement.type !== "checkbox") {
             switch (getVirtualKey(ev)) {
             case "Escape":
                 handleEscape(ev);
diff --git a/src/test/rustdoc-gui/settings.goml b/src/test/rustdoc-gui/settings.goml
index a43c712ef9a..49478775b05 100644
--- a/src/test/rustdoc-gui/settings.goml
+++ b/src/test/rustdoc-gui/settings.goml
@@ -122,6 +122,7 @@ click: ".setting-line:last-child .toggle .label"
 assert-local-storage: {"rustdoc-disable-shortcuts": "true"}
 
 // Make sure that "Disable keyboard shortcuts" actually took effect.
+// The help popover won't exist yet.
 press-key: "?"
 wait-for-css: ("#settings-menu .popover", {"display": "block"})