diff options
| author | bors <bors@rust-lang.org> | 2014-07-06 17:06:36 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2014-07-06 17:06:36 +0000 |
| commit | f601c3e7c3e35c49752006b83d2580ca6349b852 (patch) | |
| tree | 6612726c32d00211513e992053b8c38b3100b02f | |
| parent | 00a32f2f183078763aec4a96c6e81887530cc816 (diff) | |
| parent | ed3eee2e2a706d568f090f5d9862f0888dbdf670 (diff) | |
auto merge of #15465 : SimonSapin/rust/patch-4, r=alexcrichton
`Vec::push_all` with a length 1 slice seems to have significant overhead compared to `Vec::push`.
```
test new_push_byte ... bench: 6985 ns/iter (+/- 487) = 17 MB/s
test old_push_byte ... bench: 19335 ns/iter (+/- 1368) = 6 MB/s
```
```rust
extern crate test;
use test::Bencher;
static TEXT: &'static str = "\
Unicode est un standard informatique qui permet des échanges \
de textes dans différentes langues, à un niveau mondial.";
#[bench]
fn old_push_byte(bencher: &mut Bencher) {
bencher.bytes = TEXT.len() as u64;
bencher.iter(|| {
let mut new = String::new();
for b in TEXT.bytes() {
unsafe { new.as_mut_vec().push_all([b]) }
}
})
}
#[bench]
fn new_push_byte(bencher: &mut Bencher) {
bencher.bytes = TEXT.len() as u64;
bencher.iter(|| {
let mut new = String::new();
for b in TEXT.bytes() {
unsafe { new.as_mut_vec().push(b) }
}
})
}
```
| -rw-r--r-- | src/libcollections/string.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libcollections/string.rs b/src/libcollections/string.rs index 936e60388a6..e1467d957d7 100644 --- a/src/libcollections/string.rs +++ b/src/libcollections/string.rs @@ -208,7 +208,7 @@ impl String { /// Appends a byte to this string buffer. The caller must preserve the valid UTF-8 property. #[inline] pub unsafe fn push_byte(&mut self, byte: u8) { - self.push_bytes([byte]) + self.vec.push(byte) } /// Removes the last byte from the string buffer and returns it. Returns `None` if this string |
