about summary refs log tree commit diff
diff options
context:
space:
mode:
authorYuki Okushi <huyuumi.dev@gmail.com>2021-03-14 13:07:37 +0900
committerGitHub <noreply@github.com>2021-03-14 13:07:37 +0900
commitf8206ac63d001fdadbdfc4ec38806f892e4fc2d9 (patch)
tree18d422e623aa82ca72544dd4c495aeb0d9931652
parentbc79367d32a03282d4d67edf8c55ebc8e5ed7ace (diff)
parent7ecb5d86014f4da127c3d17c4b9fea3b344e7cde (diff)
downloadrust-f8206ac63d001fdadbdfc4ec38806f892e4fc2d9.tar.gz
rust-f8206ac63d001fdadbdfc4ec38806f892e4fc2d9.zip
Rollup merge of #83081 - hyd-dev:assert-message, r=m-ou-se
Fix panic message of `assert_failed_inner`

cc https://github.com/rust-lang/rust/pull/79100#discussion_r593731020

r? ``@m-ou-se``
-rw-r--r--library/core/src/panicking.rs2
-rw-r--r--src/test/ui/macros/assert-eq-macro-msg.rs9
-rw-r--r--src/test/ui/macros/assert-matches-macro-msg.rs11
-rw-r--r--src/test/ui/macros/assert-ne-macro-msg.rs9
4 files changed, 30 insertions, 1 deletions
diff --git a/library/core/src/panicking.rs b/library/core/src/panicking.rs
index 12acf5b4329..3e3e96fcd7f 100644
--- a/library/core/src/panicking.rs
+++ b/library/core/src/panicking.rs
@@ -154,7 +154,7 @@ fn assert_failed_inner(
         Some(args) => panic!(
             r#"assertion failed: `(left {} right)`
   left: `{:?}`,
- right: `{:?}: {}`"#,
+ right: `{:?}`: {}"#,
             op, left, right, args
         ),
         None => panic!(
diff --git a/src/test/ui/macros/assert-eq-macro-msg.rs b/src/test/ui/macros/assert-eq-macro-msg.rs
new file mode 100644
index 00000000000..accbd2d1e7f
--- /dev/null
+++ b/src/test/ui/macros/assert-eq-macro-msg.rs
@@ -0,0 +1,9 @@
+// run-fail
+// error-pattern:panicked at 'assertion failed: `(left == right)`
+// error-pattern: left: `2`
+// error-pattern:right: `3`: 1 + 1 definitely should be 3'
+// ignore-emscripten no processes
+
+fn main() {
+    assert_eq!(1 + 1, 3, "1 + 1 definitely should be 3");
+}
diff --git a/src/test/ui/macros/assert-matches-macro-msg.rs b/src/test/ui/macros/assert-matches-macro-msg.rs
new file mode 100644
index 00000000000..43be9532f5d
--- /dev/null
+++ b/src/test/ui/macros/assert-matches-macro-msg.rs
@@ -0,0 +1,11 @@
+// run-fail
+// error-pattern:panicked at 'assertion failed: `(left matches right)`
+// error-pattern: left: `2`
+// error-pattern:right: `3`: 1 + 1 definitely should be 3'
+// ignore-emscripten no processes
+
+#![feature(assert_matches)]
+
+fn main() {
+    assert_matches!(1 + 1, 3, "1 + 1 definitely should be 3");
+}
diff --git a/src/test/ui/macros/assert-ne-macro-msg.rs b/src/test/ui/macros/assert-ne-macro-msg.rs
new file mode 100644
index 00000000000..fc0472b99b4
--- /dev/null
+++ b/src/test/ui/macros/assert-ne-macro-msg.rs
@@ -0,0 +1,9 @@
+// run-fail
+// error-pattern:panicked at 'assertion failed: `(left != right)`
+// error-pattern: left: `2`
+// error-pattern:right: `2`: 1 + 1 definitely should not be 2'
+// ignore-emscripten no processes
+
+fn main() {
+    assert_ne!(1 + 1, 2, "1 + 1 definitely should not be 2");
+}