diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2023-11-17 00:41:24 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-11-17 00:41:24 +0100 |
| commit | f82fefd11ee959dc5a6d04a56331828d7fffd78d (patch) | |
| tree | 59c738cef398737f51166a6eda10f09bb6a40a81 | |
| parent | 743715121272300b19056711f4ee600352055f0a (diff) | |
| parent | 776146e9ebb6bbe17a37bfad955f3dac95317275 (diff) | |
| download | rust-f82fefd11ee959dc5a6d04a56331828d7fffd78d.tar.gz rust-f82fefd11ee959dc5a6d04a56331828d7fffd78d.zip | |
Rollup merge of #117982 - cuviper:quiet-pgo, r=onur-ozkan
bootstrap: only show PGO warnings when verbose Building rustc with `--rust-profile-use` is currently dumping a lot of warnings of "no profile data available for function" from `rustc_smir` and `stable_mir`. These simply aren't exercised by the current profile- gathering steps, but that's to be expected for new or experimental functionality. I think for most people, these warnings will be just noise, so it makes sense to only have them in verbose builds.
| -rw-r--r-- | src/bootstrap/src/core/build_steps/compile.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/bootstrap/src/core/build_steps/compile.rs b/src/bootstrap/src/core/build_steps/compile.rs index af69860df1c..51e4195827f 100644 --- a/src/bootstrap/src/core/build_steps/compile.rs +++ b/src/bootstrap/src/core/build_steps/compile.rs @@ -887,7 +887,9 @@ impl Step for Rustc { } else if let Some(path) = &builder.config.rust_profile_use { if compiler.stage == 1 { cargo.rustflag(&format!("-Cprofile-use={path}")); - cargo.rustflag("-Cllvm-args=-pgo-warn-missing-function"); + if builder.is_verbose() { + cargo.rustflag("-Cllvm-args=-pgo-warn-missing-function"); + } true } else { false |