diff options
| author | León Orell Valerian Liehr <me@fmease.dev> | 2024-05-23 20:09:08 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-23 20:09:08 +0200 |
| commit | f862f6d292bd60eccf5e64dc2acfa6b369f1a263 (patch) | |
| tree | fe7844e8276165ea7bff2a37b643a7cded0016d6 | |
| parent | c99b3f24c2123fd07b4956a18579aa4e685324bb (diff) | |
| parent | c2d2df182aae08fd9022e5e8977f63f69aa485a0 (diff) | |
| download | rust-f862f6d292bd60eccf5e64dc2acfa6b369f1a263.tar.gz rust-f862f6d292bd60eccf5e64dc2acfa6b369f1a263.zip | |
Rollup merge of #124389 - CensoredUsername:master, r=petrochenkov
Add a warning to proc_macro::Delimiter::None that rustc currently does not respect it. It does not provide the behaviour it is indicated to provide when used in a proc_macro context. This seems to be a bug, (https://github.com/rust-lang/rust/issues/67062), but it is a long standing one, and hard to discover. This pull request adds a warning to inform users of this issue, with a link to the relevant issue, and a version number of the last known affected rustc version.
| -rw-r--r-- | library/proc_macro/src/lib.rs | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/library/proc_macro/src/lib.rs b/library/proc_macro/src/lib.rs index 23ae2e7dc0d..3d7d36b27e5 100644 --- a/library/proc_macro/src/lib.rs +++ b/library/proc_macro/src/lib.rs @@ -815,6 +815,18 @@ pub enum Delimiter { /// "macro variable" `$var`. It is important to preserve operator priorities in cases like /// `$var * 3` where `$var` is `1 + 2`. /// Invisible delimiters might not survive roundtrip of a token stream through a string. + /// + /// <div class="warning"> + /// + /// Note: rustc currently can ignore the grouping of tokens delimited by `None` in the output + /// of a proc_macro. Only `None`-delimited groups created by a macro_rules macro in the input + /// of a proc_macro macro are preserved, and only in very specific circumstances. + /// Any `None`-delimited groups (re)created by a proc_macro will therefore not preserve + /// operator priorities as indicated above. The other `Delimiter` variants should be used + /// instead in this context. This is a rustc bug. For details, see + /// [rust-lang/rust#67062](https://github.com/rust-lang/rust/issues/67062). + /// + /// </div> #[stable(feature = "proc_macro_lib2", since = "1.29.0")] None, } |
