diff options
| author | Philipp Hansch <dev@phansch.net> | 2018-09-20 06:56:13 +0200 |
|---|---|---|
| committer | Philipp Hansch <dev@phansch.net> | 2018-09-20 06:56:51 +0200 |
| commit | f9511bfdc3753f22cfc33d53159bcd4226c307c2 (patch) | |
| tree | be63acc566c4c7e1d985078ef53d7f2d02dbbf81 | |
| parent | 9c50aa88105946a979afcfe0b2780195e73c2331 (diff) | |
| download | rust-f9511bfdc3753f22cfc33d53159bcd4226c307c2.tar.gz rust-f9511bfdc3753f22cfc33d53159bcd4226c307c2.zip | |
s/rust/Rust, repeat 'Clippy' less
| -rw-r--r-- | CONTRIBUTING.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fc5372bd7a0..57260b17cf7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -204,16 +204,16 @@ That's why the `else_if_without_else` example uses the `register_early_lint_pass ### Fixing build failures caused by Rust -Clippy will sometimes break because Clippy still depends on unstable internal Rust features. Most of the times we have to adapt to the changes and only very rarely there's an actual bug in rust. +Clippy will sometimes break because it still depends on unstable internal Rust features. Most of the times we have to adapt to the changes and only very rarely there's an actual bug in Rust. In order to find out why Clippy does not work properly with a new Rust commit, you can use the [rust-toolstate commit history][toolstate_commit_history]. You will then have to look for the last commit that contains `test-pass -> build-fail` or `test-pass` -> `test-fail` for the `clippy-driver` component. [Here][toolstate_commit] is an example. The commit message contains a link to the PR. The PRs are usually small enough to discover the breaking API change and if they are bigger, they likely include some discussion that may help you to fix Clippy. -Fixing build failures caused by rustc changes is also a good way to learn about actual rustc internals. +Fixing build failures caused by rustc updates, can also be a good way to learn about rustc internals. -If you decide to make Clippy work again with a Rust commit that breaks Clippy, +If you decide to make Clippy work again with a Rust commit that breaks it, you probably want to install the latest Rust from master locally and run Clippy using that version of Rust. |