diff options
| author | Yuki Okushi <huyuumi.dev@gmail.com> | 2020-01-07 01:39:50 +0900 |
|---|---|---|
| committer | Yuki Okushi <huyuumi.dev@gmail.com> | 2020-01-07 01:46:33 +0900 |
| commit | 2f2eaf8b7ec5073f64fcfd82f91f2f48081832ee (patch) | |
| tree | 7cf00f784c6f9306e713b9808811a8027a3ca996 /clippy_lints/src/methods | |
| parent | 732825dcff6d1f115225305ce5e0c9c9d876a0ff (diff) | |
| download | rust-2f2eaf8b7ec5073f64fcfd82f91f2f48081832ee.tar.gz rust-2f2eaf8b7ec5073f64fcfd82f91f2f48081832ee.zip | |
Rustup to rust-lang/rust#67886
Diffstat (limited to 'clippy_lints/src/methods')
| -rw-r--r-- | clippy_lints/src/methods/inefficient_to_string.rs | 2 | ||||
| -rw-r--r-- | clippy_lints/src/methods/manual_saturating_arithmetic.rs | 6 | ||||
| -rw-r--r-- | clippy_lints/src/methods/mod.rs | 12 | ||||
| -rw-r--r-- | clippy_lints/src/methods/option_map_unwrap_or.rs | 8 | ||||
| -rw-r--r-- | clippy_lints/src/methods/unnecessary_filter_map.rs | 4 |
5 files changed, 16 insertions, 16 deletions
diff --git a/clippy_lints/src/methods/inefficient_to_string.rs b/clippy_lints/src/methods/inefficient_to_string.rs index 47a77b011e4..83c63ec752f 100644 --- a/clippy_lints/src/methods/inefficient_to_string.rs +++ b/clippy_lints/src/methods/inefficient_to_string.rs @@ -1,10 +1,10 @@ use super::INEFFICIENT_TO_STRING; use crate::utils::{match_def_path, paths, snippet_with_applicability, span_lint_and_then, walk_ptrs_ty_depth}; use if_chain::if_chain; -use rustc::hir; use rustc::lint::LateContext; use rustc::ty::{self, Ty}; use rustc_errors::Applicability; +use rustc_hir as hir; /// Checks for the `INEFFICIENT_TO_STRING` lint pub fn lint<'tcx>(cx: &LateContext<'_, 'tcx>, expr: &hir::Expr<'_>, arg: &hir::Expr<'_>, arg_ty: Ty<'tcx>) { diff --git a/clippy_lints/src/methods/manual_saturating_arithmetic.rs b/clippy_lints/src/methods/manual_saturating_arithmetic.rs index e6ffa332882..7f2152e294a 100644 --- a/clippy_lints/src/methods/manual_saturating_arithmetic.rs +++ b/clippy_lints/src/methods/manual_saturating_arithmetic.rs @@ -1,8 +1,8 @@ use crate::utils::{match_qpath, snippet_with_applicability, span_lint_and_sugg}; use if_chain::if_chain; -use rustc::hir; use rustc::lint::LateContext; use rustc_errors::Applicability; +use rustc_hir as hir; use rustc_target::abi::LayoutOf; use syntax::ast; @@ -146,7 +146,7 @@ fn is_min_or_max<'tcx>(cx: &LateContext<'_, 'tcx>, expr: &hir::Expr<'_>) -> Opti } if ty.is_signed() { - if let hir::ExprKind::Unary(hir::UnNeg, val) = &expr.kind { + if let hir::ExprKind::Unary(hir::UnOp::UnNeg, val) = &expr.kind { return check_lit(val, true); } } @@ -161,7 +161,7 @@ enum Sign { } fn lit_sign(expr: &hir::Expr<'_>) -> Option<Sign> { - if let hir::ExprKind::Unary(hir::UnNeg, inner) = &expr.kind { + if let hir::ExprKind::Unary(hir::UnOp::UnNeg, inner) = &expr.kind { if let hir::ExprKind::Lit(..) = &inner.kind { return Some(Sign::Neg); } diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs index 27a8b61fdba..c33dae6c283 100644 --- a/clippy_lints/src/methods/mod.rs +++ b/clippy_lints/src/methods/mod.rs @@ -10,11 +10,11 @@ use std::iter; use if_chain::if_chain; use matches::matches; use rustc::declare_lint_pass; -use rustc::hir; use rustc::hir::intravisit::{self, Visitor}; use rustc::lint::{in_external_macro, LateContext, LateLintPass, Lint, LintArray, LintContext, LintPass}; use rustc::ty::{self, Predicate, Ty}; use rustc_errors::Applicability; +use rustc_hir as hir; use rustc_session::declare_tool_lint; use rustc_span::source_map::Span; use rustc_span::symbol::{sym, Symbol, SymbolStr}; @@ -3163,11 +3163,11 @@ impl OutType { fn matches(self, cx: &LateContext<'_, '_>, ty: &hir::FunctionRetTy<'_>) -> bool { let is_unit = |ty: &hir::Ty<'_>| SpanlessEq::new(cx).eq_ty_kind(&ty.kind, &hir::TyKind::Tup(&[])); match (self, ty) { - (Self::Unit, &hir::DefaultReturn(_)) => true, - (Self::Unit, &hir::Return(ref ty)) if is_unit(ty) => true, - (Self::Bool, &hir::Return(ref ty)) if is_bool(ty) => true, - (Self::Any, &hir::Return(ref ty)) if !is_unit(ty) => true, - (Self::Ref, &hir::Return(ref ty)) => matches!(ty.kind, hir::TyKind::Rptr(_, _)), + (Self::Unit, &hir::FunctionRetTy::DefaultReturn(_)) => true, + (Self::Unit, &hir::FunctionRetTy::Return(ref ty)) if is_unit(ty) => true, + (Self::Bool, &hir::FunctionRetTy::Return(ref ty)) if is_bool(ty) => true, + (Self::Any, &hir::FunctionRetTy::Return(ref ty)) if !is_unit(ty) => true, + (Self::Ref, &hir::FunctionRetTy::Return(ref ty)) => matches!(ty.kind, hir::TyKind::Rptr(_, _)), _ => false, } } diff --git a/clippy_lints/src/methods/option_map_unwrap_or.rs b/clippy_lints/src/methods/option_map_unwrap_or.rs index 696f74d36db..c9cb17e965e 100644 --- a/clippy_lints/src/methods/option_map_unwrap_or.rs +++ b/clippy_lints/src/methods/option_map_unwrap_or.rs @@ -1,10 +1,10 @@ use crate::utils::{differing_macro_contexts, paths, snippet_with_applicability, span_lint_and_then}; use crate::utils::{is_copy, match_type}; use rustc::hir::intravisit::{walk_path, NestedVisitorMap, Visitor}; -use rustc::hir::{self, *}; use rustc::lint::LateContext; use rustc_data_structures::fx::FxHashSet; use rustc_errors::Applicability; +use rustc_hir::{self, *}; use rustc_span::source_map::Span; use rustc_span::symbol::Symbol; @@ -13,9 +13,9 @@ use super::OPTION_MAP_UNWRAP_OR; /// lint use of `map().unwrap_or()` for `Option`s pub(super) fn lint<'a, 'tcx>( cx: &LateContext<'a, 'tcx>, - expr: &hir::Expr<'_>, - map_args: &'tcx [hir::Expr<'_>], - unwrap_args: &'tcx [hir::Expr<'_>], + expr: &rustc_hir::Expr<'_>, + map_args: &'tcx [rustc_hir::Expr<'_>], + unwrap_args: &'tcx [rustc_hir::Expr<'_>], map_span: Span, ) { // lint if the caller of `map()` is an `Option` diff --git a/clippy_lints/src/methods/unnecessary_filter_map.rs b/clippy_lints/src/methods/unnecessary_filter_map.rs index 567b3db1e82..b77a40c6fc0 100644 --- a/clippy_lints/src/methods/unnecessary_filter_map.rs +++ b/clippy_lints/src/methods/unnecessary_filter_map.rs @@ -1,10 +1,10 @@ use crate::utils::paths; use crate::utils::usage::mutated_variables; use crate::utils::{match_qpath, match_trait_method, span_lint}; -use rustc::hir; -use rustc::hir::def::Res; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; use rustc::lint::LateContext; +use rustc_hir as hir; +use rustc_hir::def::Res; use if_chain::if_chain; |
