diff options
| author | Jason Newcomb <jsnewcomb@pm.me> | 2024-07-12 00:00:03 -0400 |
|---|---|---|
| committer | Jason Newcomb <jsnewcomb@pm.me> | 2024-07-17 14:05:49 -0400 |
| commit | e34c6dbae5768b5dce90c02465f3492376327c65 (patch) | |
| tree | 116eadb846c5d9274bf08e48bfbcda6f47a0fbd9 /clippy_lints/src/utils | |
| parent | 0ee9f44568b60aaef5d04684cb08f112edd89542 (diff) | |
Refactor for using config values:
* Construct lint passes by taking `Conf` by reference. * Use `HashSet` configs in less places * Move some `check_crate` code into the pass constructor when possible.
Diffstat (limited to 'clippy_lints/src/utils')
3 files changed, 4 insertions, 4 deletions
diff --git a/clippy_lints/src/utils/internal_lints/interning_defined_symbol.rs b/clippy_lints/src/utils/internal_lints/interning_defined_symbol.rs index 07879e81fc2..b017a6bf665 100644 --- a/clippy_lints/src/utils/internal_lints/interning_defined_symbol.rs +++ b/clippy_lints/src/utils/internal_lints/interning_defined_symbol.rs @@ -74,7 +74,7 @@ impl<'tcx> LateLintPass<'tcx> for InterningDefinedSymbol { } for &module in &[&paths::KW_MODULE, &paths::SYM_MODULE] { - for def_id in def_path_def_ids(cx, module) { + for def_id in def_path_def_ids(cx.tcx, module) { for item in cx.tcx.module_children(def_id) { if let Res::Def(DefKind::Const, item_def_id) = item.res && let ty = cx.tcx.type_of(item_def_id).instantiate_identity() diff --git a/clippy_lints/src/utils/internal_lints/invalid_paths.rs b/clippy_lints/src/utils/internal_lints/invalid_paths.rs index 0beb0bb8ed4..980437259c3 100644 --- a/clippy_lints/src/utils/internal_lints/invalid_paths.rs +++ b/clippy_lints/src/utils/internal_lints/invalid_paths.rs @@ -55,7 +55,7 @@ impl<'tcx> LateLintPass<'tcx> for InvalidPaths { // This is not a complete resolver for paths. It works on all the paths currently used in the paths // module. That's all it does and all it needs to do. pub fn check_path(cx: &LateContext<'_>, path: &[&str]) -> bool { - if !def_path_res(cx, path).is_empty() { + if !def_path_res(cx.tcx, path).is_empty() { return true; } diff --git a/clippy_lints/src/utils/internal_lints/unnecessary_def_path.rs b/clippy_lints/src/utils/internal_lints/unnecessary_def_path.rs index 8cf42832761..41183700f09 100644 --- a/clippy_lints/src/utils/internal_lints/unnecessary_def_path.rs +++ b/clippy_lints/src/utils/internal_lints/unnecessary_def_path.rs @@ -108,7 +108,7 @@ impl UnnecessaryDefPath { // Extract the path to the matched type && let Some(segments) = path_to_matched_type(cx, item_arg) && let segments = segments.iter().map(|sym| &**sym).collect::<Vec<_>>() - && let Some(def_id) = def_path_def_ids(cx, &segments[..]).next() + && let Some(def_id) = def_path_def_ids(cx.tcx, &segments[..]).next() { // Check if the target item is a diagnostic item or LangItem. #[rustfmt::skip] @@ -206,7 +206,7 @@ impl UnnecessaryDefPath { fn check_array(&mut self, cx: &LateContext<'_>, elements: &[Expr<'_>], span: Span) { let Some(path) = path_from_array(elements) else { return }; - for def_id in def_path_def_ids(cx, &path.iter().map(AsRef::as_ref).collect::<Vec<_>>()) { + for def_id in def_path_def_ids(cx.tcx, &path.iter().map(AsRef::as_ref).collect::<Vec<_>>()) { self.array_def_ids.insert((def_id, span)); } } |
