diff options
| author | unexge <unexge@gmail.com> | 2023-02-18 19:18:52 +0000 |
|---|---|---|
| committer | unexge <unexge@gmail.com> | 2023-03-08 08:51:50 +0000 |
| commit | b4b2b1235a07aeb5f6d6e345e23d8fa4873cda08 (patch) | |
| tree | 1fa1635d2f775eb40b997099c0b3e0543a33c082 /clippy_lints/src | |
| parent | 6fac73b9874ea79fbac5f0fa9429c726c196d9a6 (diff) | |
| download | rust-b4b2b1235a07aeb5f6d6e345e23d8fa4873cda08.tar.gz rust-b4b2b1235a07aeb5f6d6e345e23d8fa4873cda08.zip | |
Revert "Dogfood `missing_assert_message` on Clippy"
This reverts commit ec653570ad50d11ecc3b5649dd28e29ed96199d3.
Diffstat (limited to 'clippy_lints/src')
| -rw-r--r-- | clippy_lints/src/doc.rs | 2 | ||||
| -rw-r--r-- | clippy_lints/src/duplicate_mod.rs | 6 | ||||
| -rw-r--r-- | clippy_lints/src/enum_variants.rs | 2 | ||||
| -rw-r--r-- | clippy_lints/src/non_expressive_names.rs | 5 |
4 files changed, 4 insertions, 11 deletions
diff --git a/clippy_lints/src/doc.rs b/clippy_lints/src/doc.rs index b1c2a51daa0..384aca7fead 100644 --- a/clippy_lints/src/doc.rs +++ b/clippy_lints/src/doc.rs @@ -467,7 +467,7 @@ pub fn strip_doc_comment_decoration(doc: &str, comment_kind: CommentKind, span: let mut contains_initial_stars = false; for line in doc.lines() { let offset = line.as_ptr() as usize - doc.as_ptr() as usize; - debug_assert_eq!(offset as u32 as usize, offset, "`offset` shouldn't overflow `u32`"); + debug_assert_eq!(offset as u32 as usize, offset); contains_initial_stars |= line.trim_start().starts_with('*'); // +1 adds the newline, +3 skips the opening delimiter sizes.push((line.len() + 1, span.with_lo(span.lo() + BytePos(3 + offset as u32)))); diff --git a/clippy_lints/src/duplicate_mod.rs b/clippy_lints/src/duplicate_mod.rs index 9135af40979..7ff7068f0b0 100644 --- a/clippy_lints/src/duplicate_mod.rs +++ b/clippy_lints/src/duplicate_mod.rs @@ -90,11 +90,7 @@ impl EarlyLintPass for DuplicateMod { } // At this point the lint would be emitted - assert_eq!( - spans.len(), - lint_levels.len(), - "`spans` and `lint_levels` should have equal lengths" - ); + assert_eq!(spans.len(), lint_levels.len()); let spans: Vec<_> = spans .iter() .zip(lint_levels) diff --git a/clippy_lints/src/enum_variants.rs b/clippy_lints/src/enum_variants.rs index 68fb88bcf7e..4c69dacf381 100644 --- a/clippy_lints/src/enum_variants.rs +++ b/clippy_lints/src/enum_variants.rs @@ -242,7 +242,7 @@ fn to_camel_case(item_name: &str) -> String { impl LateLintPass<'_> for EnumVariantNames { fn check_item_post(&mut self, _cx: &LateContext<'_>, _item: &Item<'_>) { let last = self.modules.pop(); - assert!(last.is_some(), "`modules` should not be empty"); + assert!(last.is_some()); } #[expect(clippy::similar_names)] diff --git a/clippy_lints/src/non_expressive_names.rs b/clippy_lints/src/non_expressive_names.rs index e24f3aa567a..9f6917c146f 100644 --- a/clippy_lints/src/non_expressive_names.rs +++ b/clippy_lints/src/non_expressive_names.rs @@ -408,10 +408,7 @@ fn do_check(lint: &mut NonExpressiveNames, cx: &EarlyContext<'_>, attrs: &[Attri /// Precondition: `a_name.chars().count() < b_name.chars().count()`. #[must_use] fn levenstein_not_1(a_name: &str, b_name: &str) -> bool { - debug_assert!( - a_name.chars().count() < b_name.chars().count(), - "Precondition: `a_name.chars().count() < b_name.chars().count()` does not meet" - ); + debug_assert!(a_name.chars().count() < b_name.chars().count()); let mut a_chars = a_name.chars(); let mut b_chars = b_name.chars(); while let (Some(a), Some(b)) = (a_chars.next(), b_chars.next()) { |
