diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2023-11-18 22:33:01 +0100 |
|---|---|---|
| committer | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2023-11-19 22:46:19 +0100 |
| commit | dfbca7ffa8e0f7d69374f5f6dd351cc34ed0e811 (patch) | |
| tree | 5e549fb7f5784573448fe479262dd92f4a70c36c /clippy_lints | |
| parent | 6eb935a578f7b2fcd87377bd571c4ff1dec48982 (diff) | |
Improve `maybe_misused_cfg` lint output
Small performance improvement when comparing symbols for `maybe_misused_cfg` Improve suggestion for `maybe_misused_cfg` lint
Diffstat (limited to 'clippy_lints')
| -rw-r--r-- | clippy_lints/src/attrs.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs index 9fe1ef2ed14..0a4a0ab9f07 100644 --- a/clippy_lints/src/attrs.rs +++ b/clippy_lints/src/attrs.rs @@ -929,15 +929,16 @@ fn check_nested_cfg(cx: &EarlyContext<'_>, items: &[NestedMetaItem]) { fn check_nested_misused_cfg(cx: &EarlyContext<'_>, items: &[NestedMetaItem]) { for item in items { if let NestedMetaItem::MetaItem(meta) = item { - if meta.has_name(sym!(features)) + if let Some(ident) = meta.ident() + && ident.name.as_str() == "features" && let Some(val) = meta.value_str() { span_lint_and_sugg( cx, MAYBE_MISUSED_CFG, meta.span, - "feature may misspelled as features", - "use", + "'feature' may be misspelled as 'features'", + "did you mean", format!("feature = \"{val}\""), Applicability::MaybeIncorrect, ); @@ -953,7 +954,7 @@ fn check_nested_misused_cfg(cx: &EarlyContext<'_>, items: &[NestedMetaItem]) { MAYBE_MISUSED_CFG, meta.span, &format!("'test' may be misspelled as '{}'", ident.name.as_str()), - "do you mean", + "did you mean", "test".to_string(), Applicability::MaybeIncorrect, ); |
